New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 596520 link

Starred by 2 users
Status: Fixed
Owner:
█ mkwst@chromium.org
Buried. Ping if important.
Closed: Apr 2016
Cc:
█ rnimmagadda@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 459154



Sign in to add a comment

`SameSite=Lax` not showing checkmark in `Same-Site` column Resrouces->Cookies tab

Reported by bto...@github.com, Mar 21 2016 
Chrome Version       : 51.0.2686.0
OS Version: OS X 10.11.3
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5:
  Firefox 4.x:
     IE 7/8/9:

What steps will reproduce the problem?
1. Server sends `SameSite=Lax` cookie attribute
2. Check mark shows up in Network->Cookies tab, but not Resources->Cookies tab.

What is the expected result?

Check mark shows up in Resources->Cookies tab.


What happens instead of that?

It didn't show up.

Please provide any additional information below. Attach a screenshot if
possible.

Comment 1 by rnimmagadda@chromium.org, Mar 22 2016

Cc: rnimmagadda@chromium.org
Labels: Needs-Feedback
@btoews: Could you please provide us the screen-recording for better understanding of this issue, which would help us in triaging it further.

Thank you.

Comment 2 by mkwst@chromium.org, Mar 22 2016

Blocking: 459154

Comment 3 by mkwst@chromium.org, Mar 22 2016

Components: Blink>SecurityFeature Platform>DevTools>Network
Labels: -Needs-Feedback
Owner: mkwst@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 4 by bto...@github.com, Mar 22 2016

asdf.gif
306 KB View Download

Comment 5 by mkwst@chromium.org, Mar 23 2016 

https://codereview.chromium.org/1827743002 up for review.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e0bddf6d2123979b95860fae65429014828b33f

commit 4e0bddf6d2123979b95860fae65429014828b33f
Author: mkwst <mkwst@chromium.org>
Date: Wed Apr 06 07:15:52 2016

SameSite: Teach devtools about the new 'samesite' syntax.

We used to treat 'samesite' as a binary flag, displaying a checkmark
just like 'secure' or 'httponly'. The attribute is now a trinary value in
the table: "", "Lax", or "Strict".

The protocol shifted to align with this change, switching from a boolean
value to an enum ("NoRestriction", "Lax", and "Strict", respectively).

BUG= 596520 

Review URL: https://codereview.chromium.org/1827743002

Cr-Commit-Position: refs/heads/master@{#385393}

[modify] https://crrev.com/4e0bddf6d2123979b95860fae65429014828b33f/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/4e0bddf6d2123979b95860fae65429014828b33f/third_party/WebKit/LayoutTests/http/tests/inspector/resource-har-conversion-expected.txt
[modify] https://crrev.com/4e0bddf6d2123979b95860fae65429014828b33f/third_party/WebKit/LayoutTests/http/tests/inspector/resource-har-conversion.html
[modify] https://crrev.com/4e0bddf6d2123979b95860fae65429014828b33f/third_party/WebKit/LayoutTests/inspector/components/cookie-parser-expected.txt
[modify] https://crrev.com/4e0bddf6d2123979b95860fae65429014828b33f/third_party/WebKit/LayoutTests/inspector/components/cookie-parser.html
[modify] https://crrev.com/4e0bddf6d2123979b95860fae65429014828b33f/third_party/WebKit/LayoutTests/inspector/cookie-resource-match.html
[modify] https://crrev.com/4e0bddf6d2123979b95860fae65429014828b33f/third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js
[modify] https://crrev.com/4e0bddf6d2123979b95860fae65429014828b33f/third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js
[modify] https://crrev.com/4e0bddf6d2123979b95860fae65429014828b33f/third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js
[modify] https://crrev.com/4e0bddf6d2123979b95860fae65429014828b33f/third_party/WebKit/Source/devtools/protocol.json

Comment 7 by mkwst@chromium.org, Apr 6 2016

Status: Fixed (was: Assigned)

Comment 8 by l446240525@gmail.com, Apr 6 2016 

If the "SameSite" attribute has no value, or if the value is invalid, DevTools should display "Strict" or empty?
2332.png
139 KB View Download

Comment 9 by mkwst@chromium.org, Apr 6 2016 

Hrm. That should be strict, but I don't think it's a devtools problem. I think it's a parser bug. :/

Would you mind filing a distinct issue? I'll poke at that today.
►

Sign in to add a comment