New issue
Advanced search Search tips

Issue 596515 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Don't offer to upload cards already present on the server just because the name or exp date differs

Project Member Reported by jdonnelly@chromium.org, Mar 21 2016

Issue description

If the credit card number matches a server card, an upload is guaranteed to fail.

The existing logic is derived from local card handling where if the name or expiration date is different we offer to save a card even if we already have an autofill entry with that exact card number. But in the case of upload, this will never succeed.
 
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee7e2c11cc024f60c32dc2e69433e417e8f34234

commit ee7e2c11cc024f60c32dc2e69433e417e8f34234
Author: jdonnelly <jdonnelly@chromium.org>
Date: Fri Mar 18 15:34:00 2016

Don't ever attempt to upload credit cards whose numbers match.

Previously, we were using the logic derived from local card handling where if the name or expiration date was different we would offer to save a card even if we already had an autofill entry with that exact card number. But in the case of upload, this will never succeed.

BUG=535784

Review URL: https://codereview.chromium.org/1808613004

Cr-Commit-Position: refs/heads/master@{#381974}

[modify] https://crrev.com/ee7e2c11cc024f60c32dc2e69433e417e8f34234/components/autofill/core/browser/credit_card.cc
[modify] https://crrev.com/ee7e2c11cc024f60c32dc2e69433e417e8f34234/components/autofill/core/browser/credit_card.h
[modify] https://crrev.com/ee7e2c11cc024f60c32dc2e69433e417e8f34234/components/autofill/core/browser/credit_card_unittest.cc
[modify] https://crrev.com/ee7e2c11cc024f60c32dc2e69433e417e8f34234/components/autofill/core/browser/personal_data_manager.cc
Labels: Merge-Request-50

Comment 3 by tin...@google.com, Mar 22 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 22 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/901f76da1b2561b550517c69e3a5f6a1278e7e7c

commit 901f76da1b2561b550517c69e3a5f6a1278e7e7c
Author: Justin Donnelly <jdonnelly@chromium.org>
Date: Tue Mar 22 17:58:42 2016

Don't ever attempt to upload credit cards whose numbers match.

Previously, we were using the logic derived from local card handling where if the name or expiration date was different we would offer to save a card even if we already had an autofill entry with that exact card number. But in the case of upload, this will never succeed.

BUG= 596515 

Review URL: https://codereview.chromium.org/1808613004

Cr-Commit-Position: refs/heads/master@{#381974}
(cherry picked from commit ee7e2c11cc024f60c32dc2e69433e417e8f34234)

Review URL: https://codereview.chromium.org/1818403003 .

Cr-Commit-Position: refs/branch-heads/2661@{#345}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/901f76da1b2561b550517c69e3a5f6a1278e7e7c/components/autofill/core/browser/credit_card.cc
[modify] https://crrev.com/901f76da1b2561b550517c69e3a5f6a1278e7e7c/components/autofill/core/browser/credit_card.h
[modify] https://crrev.com/901f76da1b2561b550517c69e3a5f6a1278e7e7c/components/autofill/core/browser/credit_card_unittest.cc
[modify] https://crrev.com/901f76da1b2561b550517c69e3a5f6a1278e7e7c/components/autofill/core/browser/personal_data_manager.cc

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment