New issue
Advanced search Search tips

Issue 596514 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 622387
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows , Mac
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

AccessibilityModalDialogInIframeClosed failing on Android GN

Project Member Reported by perezju@chromium.org, Mar 21 2016

Issue description

The DumpAccessibilityTreeTest.AccessibilityModalDialogInIframeClosed test has just failed on Android GN bot:

[ RUN      ] DumpAccessibilityTreeTest.AccessibilityModalDialogInIframeClosed
[WARNING:dns_config_service_posix.cc(306)] Failed to read DnsConfig.
[ERROR:devtools_http_handler.cc(229)] Cannot start http server for devtools. Stop devtools.
[ERROR:shell.cc(302)] Error: Instance: exe:chrome attempting to register an instance for a process it created for target: exe:chrome_renderer without the mojo:shell{client_process} capability class.
[ERROR:layer_tree_host_impl.cc(2211)] Forcing zero-copy tile initialization as worker context is missing
[INFO:dump_accessibility_browsertest_base.cc(200)] Testing: /storage/emulated/0/content/test/data/accessibility/html/modal-dialog-in-iframe-closed.html (native accessibility tree for this platform)
../../content/browser/accessibility/dump_accessibility_browsertest_base.cc:339: Failure
Value of: is_different
  Actual: true
Expected: false
[ERROR:dump_accessibility_browsertest_base.cc(364)] Diff:
* Line Expected
- ---- --------
     1 android.webkit.WebView focusable focused scrollable
     2 ++android.view.View
     3 ++++android.view.View clickable name='Test for modal dialog closed in an iframe. '
     4 ++++android.view.View
*    5 ++++++android.view.View focusable scrollable
     6 ++++++++android.view.View
     7 ++++++++++android.widget.Button role_description='button' clickable focusable name='I am a non-inert button!'
     8 <-- End-of-file -->

Actual
------
android.webkit.WebView focusable focused scrollable
++android.view.View
++++android.view.View clickable name='Test for modal dialog closed in an iframe. '
++++android.view.View
<-- End-of-file -->
[  FAILED  ] DumpAccessibilityTreeTest.AccessibilityModalDialogInIframeClosed, where TypeParam =  and GetParam() =  (556 ms)

Don't see anything obvious on the CL range:
https://chromium.googlesource.com/chromium/src/+log/d26beba1c03ca7eff59252cf6f08080d1b603310%5E..f76b5035ab7d677198849bff6cd5c3aa17d78468?pretty=oneline

Assigned to falken@, you seem to be familiar with this test.
 

Comment 2 by falken@chromium.org, Mar 24 2016

Components: UI>Accessibility Blink>HTML>Dialog
Looks like that bot flaked once but not after that.

Comment 3 by peter@chromium.org, Mar 29 2016

It's failing quite a lot on the low-end Lollipop tester:

https://build.chromium.org/p/chromium.android/builders/Lollipop%20Low-end%20Tester

And very occasionally for the Lillipop tablet tester here:

https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester

Comment 5 by ti...@chromium.org, Apr 13 2016

Labels: -Pri-3 Pri-2
Recent failure on Android Test (dbg):
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20(dbg)/builds/33865

Shall I disable this test?

Comment 6 by dgn@chromium.org, Apr 22 2016

Cc: peconn@chromium.org dmazz...@chromium.org
 Issue 595283  has been merged into this issue.

Comment 7 by dgn@chromium.org, Apr 22 2016

Cc: nyerramilli@chromium.org
 Issue 593846  has been merged into this issue.

Comment 8 by dgn@chromium.org, Apr 22 2016

Labels: OS-Android OS-Mac OS-Windows
I'm not quite sure what the test is supposed to achieve. The code[1] closes the dialog, but we expect it to be shown [2]?

I'll disable it.

[1]: https://code.google.com/p/chromium/codesearch#chromium/src/content/test/data/accessibility/html/modal-dialog-in-iframe-closed.html
[2]: https://chromium.googlesource.com/chromium/src/+/f27bf8991392753e2a53d9869bffaeb827b5a4eb
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa840b1d9f872829c22b52769034e85b3deba1af

commit fa840b1d9f872829c22b52769034e85b3deba1af
Author: dgn <dgn@chromium.org>
Date: Fri Apr 22 11:19:27 2016

Disable DumpAccessibilityTreeTest.AccessibilityModalDialogInIframeClosed

The test is flaky on Android too, not just Win and Mac. Disabling
everywhere.

BUG= 596514 
TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/1905313002

Cr-Commit-Position: refs/heads/master@{#389073}

[modify] https://crrev.com/fa840b1d9f872829c22b52769034e85b3deba1af/content/browser/accessibility/dump_accessibility_tree_browsertest.cc

Comment 10 by dgn@chromium.org, Apr 22 2016

About #c8, I misunderstood the test, it looks like it should work. But it's flaky anyway. Also, I didn't disable AccessibilityModalDialogInIframeOpen yet. That one is disabled on Mac and Win but would still run on other platforms for now.

Cc: -dmazz...@chromium.org
Owner: dmazz...@chromium.org
dmazzoni, can you look at this, as it appears caused by:
https://codereview.chromium.org/1761633002

It looks like both  AccessibilityModalDialogInIframe{Closed,Opened} became flaky after that, as per  issue 593846 .

Mergedinto: 622387
Status: Duplicate (was: Assigned)

Sign in to add a comment