New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596509 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
NOT IN USE
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Use LocalStyleChange for text direction changes

Reported by r...@opera.com, Mar 21 2016

Issue description

Modifications to direction through dir attribute changes and text insertion triggers SubtreeStyleChange for the affected elements. LocalStyleChange should be enough.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19ae473e9890bba140facef0127941554a2d5718

commit 19ae473e9890bba140facef0127941554a2d5718
Author: rune <rune@opera.com>
Date: Mon Mar 21 23:53:47 2016

Use LocalStyleChange for text direction changes.

Changing the dir attribute or inserting text content into the document
may affect the CSS direction property through presentation style. The
code traversed and marked the parent elements affected by such changes
but use SubtreeStyleChange which recalculate more style than necessary.
Instead use LocalStyleChange as that will also cause inheritance to
happen appropriately.

R=kojii@chromium.org
BUG= 596509 

Review URL: https://codereview.chromium.org/1817143002

Cr-Commit-Position: refs/heads/master@{#382442}

[add] https://crrev.com/19ae473e9890bba140facef0127941554a2d5718/third_party/WebKit/LayoutTests/fast/dom/dir-auto-insert-text-invalidation-expected.txt
[add] https://crrev.com/19ae473e9890bba140facef0127941554a2d5718/third_party/WebKit/LayoutTests/fast/dom/dir-auto-insert-text-invalidation.html
[modify] https://crrev.com/19ae473e9890bba140facef0127941554a2d5718/third_party/WebKit/Source/core/html/HTMLElement.cpp

Comment 2 by r...@opera.com, Mar 22 2016

Status: Fixed (was: Started)

Sign in to add a comment