New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596506 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Cronet debug builds have icu included

Project Member Reported by mge...@chromium.org, Mar 21 2016

Issue description

ICU roll caused a sizes alert for some of the debug builders (android_cronet_x86_builder_dbg, android_cronet_arm64_builder_dbg). They're checking libcronet.so from cronet_sample_apk, which should have the non-icu version of the build target.
 
Currently one two bots are reporting the increase

https://chromeperf.appspot.com/report?sid=8871e993264c4957e155514992955f4c3c8029d10399abdf8e7b8994287f9f03&start_rev=375413&end_rev=382302&rev=382221

third_party/icu dependency might be added somewhere in the build chain for these two arch. Maybe we can try explicitly removing third_party/icu depending from net_small. 
Might worth trying building libcronet.so locally for these two arch (android_cronet_x86_builder_dbg and android_cronet_arm64_builder_dbg), and see if icu is included and if removing third_party/icu has any effect.
Owner: xunji...@chromium.org
Status: Assigned (was: Available)
I can take a look.
Labels: -Pri-3 Pri-2
Summary: Cronet debug builds have icu included (was: Sizes step on Cronet debug bots checks libcronet.so with icu included)
Cronet depends on components/metrics, which depends on base.gyp:base_i18n, which pulls in icu dependencies. 

As far as I see, base_i18n is only used for metrics/daily_event.cc/h. I am not sure what is the best solution here. I am gonna send out an email.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f8c5e9ad8a7ba8695e8efe4deb19212202e022e

commit 5f8c5e9ad8a7ba8695e8efe4deb19212202e022e
Author: xunjieli <xunjieli@chromium.org>
Date: Mon Mar 21 22:44:15 2016

Remove base_i18n dependency from //components/metrics:metrics target

base_i18n dependency is only used for a DVLOG in daily_event.cc. This CL
removes this dependency since base_i18n pulls ICU dependency which is fairly
large.

BUG= 596506 

Review URL: https://codereview.chromium.org/1819093002

Cr-Commit-Position: refs/heads/master@{#382421}

[modify] https://crrev.com/5f8c5e9ad8a7ba8695e8efe4deb19212202e022e/components/metrics.gypi
[modify] https://crrev.com/5f8c5e9ad8a7ba8695e8efe4deb19212202e022e/components/metrics/BUILD.gn
[modify] https://crrev.com/5f8c5e9ad8a7ba8695e8efe4deb19212202e022e/components/metrics/daily_event.cc

Status: Fixed (was: Assigned)
~25% reduction (or 1.6 MB) in sizes for debug builds. 
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3e57315382f03347700b7f575547b42ff0d4f0f

commit f3e57315382f03347700b7f575547b42ff0d4f0f
Author: mgersh <mgersh@chromium.org>
Date: Wed Jun 01 21:55:00 2016

Remove base_i18n dependency from cronet_static_tmpl

cronet_static will still include it depending on build flags.

BUG= 596506 

Review-Url: https://codereview.chromium.org/2028223002
Cr-Commit-Position: refs/heads/master@{#397261}

[modify] https://crrev.com/f3e57315382f03347700b7f575547b42ff0d4f0f/components/cronet/android/BUILD.gn
[modify] https://crrev.com/f3e57315382f03347700b7f575547b42ff0d4f0f/components/cronet/android/cronet_library_loader.cc

Sign in to add a comment