Cronet debug builds have icu included |
||||
Issue descriptionICU roll caused a sizes alert for some of the debug builders (android_cronet_x86_builder_dbg, android_cronet_arm64_builder_dbg). They're checking libcronet.so from cronet_sample_apk, which should have the non-icu version of the build target.
,
Mar 21 2016
Might worth trying building libcronet.so locally for these two arch (android_cronet_x86_builder_dbg and android_cronet_arm64_builder_dbg), and see if icu is included and if removing third_party/icu has any effect.
,
Mar 21 2016
I can take a look.
,
Mar 21 2016
Cronet depends on components/metrics, which depends on base.gyp:base_i18n, which pulls in icu dependencies. As far as I see, base_i18n is only used for metrics/daily_event.cc/h. I am not sure what is the best solution here. I am gonna send out an email.
,
Mar 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f8c5e9ad8a7ba8695e8efe4deb19212202e022e commit 5f8c5e9ad8a7ba8695e8efe4deb19212202e022e Author: xunjieli <xunjieli@chromium.org> Date: Mon Mar 21 22:44:15 2016 Remove base_i18n dependency from //components/metrics:metrics target base_i18n dependency is only used for a DVLOG in daily_event.cc. This CL removes this dependency since base_i18n pulls ICU dependency which is fairly large. BUG= 596506 Review URL: https://codereview.chromium.org/1819093002 Cr-Commit-Position: refs/heads/master@{#382421} [modify] https://crrev.com/5f8c5e9ad8a7ba8695e8efe4deb19212202e022e/components/metrics.gypi [modify] https://crrev.com/5f8c5e9ad8a7ba8695e8efe4deb19212202e022e/components/metrics/BUILD.gn [modify] https://crrev.com/5f8c5e9ad8a7ba8695e8efe4deb19212202e022e/components/metrics/daily_event.cc
,
Mar 22 2016
~25% reduction (or 1.6 MB) in sizes for debug builds.
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3e57315382f03347700b7f575547b42ff0d4f0f commit f3e57315382f03347700b7f575547b42ff0d4f0f Author: mgersh <mgersh@chromium.org> Date: Wed Jun 01 21:55:00 2016 Remove base_i18n dependency from cronet_static_tmpl cronet_static will still include it depending on build flags. BUG= 596506 Review-Url: https://codereview.chromium.org/2028223002 Cr-Commit-Position: refs/heads/master@{#397261} [modify] https://crrev.com/f3e57315382f03347700b7f575547b42ff0d4f0f/components/cronet/android/BUILD.gn [modify] https://crrev.com/f3e57315382f03347700b7f575547b42ff0d4f0f/components/cronet/android/cronet_library_loader.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by xunji...@chromium.org
, Mar 21 2016