New issue
Advanced search Search tips

Issue 596505 link

Starred by 1 user
Status: Verified
Owner:
nzolghadr@chromium.org
Closed: Apr 2016
Cc:
rbyers@chromium.org
mustaq@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 583688



Sign in to add a comment

lostpointercapture should be fired right after pointerup/cancel for touch events

Project Member Reported by nzolghadr@chromium.org, Mar 21 2016 
Right now we delay firing lost/gotpointercapture until the next pointer event as per spec.

For the touches tough as soon as they are released there will be no pointer events with the same id as the next touches will have a different id. So we should fire lostpointercapture if they were captured right after firing pointerup/cancel.

Comment 1 by nzolghadr@chromium.org, Mar 31 2016

Blocking: 583688
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/268b54a5f857d2d8a89199e3ada14b0afed2075e

commit 268b54a5f857d2d8a89199e3ada14b0afed2075e
Author: nzolghadr <nzolghadr@chromium.org>
Date: Tue Apr 05 18:03:03 2016

Send lostpointercapture on touch capturing

We are sending both got/lostpointercapture events on touches
by setting the implicit pointer capture right after the touch
starts.

Also sending lostpointercapture on touch released or
cancel right away after pointerup/cancel as we will never
get another pointer event with the same id to trigger
sending the lostpointercapture.

More on the interaction of pointer event capturing and
touch capturing will be addressed in  crbug.com/579553 

BUG= 596505 

Review URL: https://codereview.chromium.org/1838973003

Cr-Commit-Position: refs/heads/master@{#385219}

[add] https://crrev.com/268b54a5f857d2d8a89199e3ada14b0afed2075e/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/touch-capture-expected.txt
[add] https://crrev.com/268b54a5f857d2d8a89199e3ada14b0afed2075e/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/touch-capture.html
[modify] https://crrev.com/268b54a5f857d2d8a89199e3ada14b0afed2075e/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/268b54a5f857d2d8a89199e3ada14b0afed2075e/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
[modify] https://crrev.com/268b54a5f857d2d8a89199e3ada14b0afed2075e/third_party/WebKit/Source/core/events/PointerEventFactory.h
[modify] https://crrev.com/268b54a5f857d2d8a89199e3ada14b0afed2075e/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/268b54a5f857d2d8a89199e3ada14b0afed2075e/third_party/WebKit/Source/core/input/EventHandler.h
[modify] https://crrev.com/268b54a5f857d2d8a89199e3ada14b0afed2075e/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/268b54a5f857d2d8a89199e3ada14b0afed2075e/third_party/WebKit/Source/core/input/PointerEventManager.h

Comment 3 by nzolghadr@chromium.org, Apr 19 2016

Status: Fixed (was: Assigned)

Comment 4 by patricia@chromium.org, May 23 2016

Status: Verified (was: Fixed)
Bulk verified
►

Sign in to add a comment