New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596502 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug



Sign in to add a comment

"critical error" notification displayed incorrectly

Project Member Reported by abodenha@chromium.org, Mar 21 2016

Issue description

Version: 50.0.2661.32 (Official Build) dev (64-bit) Samus
OS: Chrome OS

1: Change password on another device
2: Log into your chromebook

Expected:
Correct "Your password has changed flow"

Actual:
"A critical error has occurred" message is shown.

tbuckley@ can you add any more detail?
 

Comment 1 by xiy...@chromium.org, Mar 21 2016

I assume that we see the UI implemented for issue 585530 for a real password change scenario. Is it possible to attach chrome log when this happened?
Yep, it's the 585530 UI.

tbuckley@, that UI gives you the option of filing a feedback report. Did you file one?

Comment 3 by xiy...@chromium.org, Mar 21 2016

Cc: dzhioev@chromium.org
Status: Started (was: Assigned)
Repro'd on a 2nd try. The problem is that we are refreshing the TokenHandle immediately after a gaia auth. When the cryptohome fails, we could be testing against the new TokenHandle and since the new one is always valid, we take user to cryptohome failure UI rather than password changed UI.

Comment 5 by xiy...@chromium.org, Mar 21 2016

Cc: keta...@chromium.org
Labels: M-50
+ketakid

Mark for M50 since the triggering code is in M50. I will request for merge after the CL lands on trunk.
Labels: M-51 ReleaseBlock-Beta
Labels: OS-Chrome
Looks like OS Chrome, please add more OSes as required.
Sounds like this is solved, but to clarify the flow I went through:
1) Change password on another device
2) Use old password to unlock signed-in Chrome OS device
3) See notification saying "password has changed, please sign out and sign in again" (or something to that affect). Click the notification
4) From sign-in screen, type new password

Expected: log in normally
Actual: see warning that there was an issue signing in and your local data will be removed
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9231ba274a1c6525bf06cfc1a214fae2967663b7

commit 9231ba274a1c6525bf06cfc1a214fae2967663b7
Author: xiyuan <xiyuan@chromium.org>
Date: Mon Mar 21 18:50:30 2016

cros: Fix unexpected cryptohome failure UI

TokenHandleFetcher::FillForNewUser should be called when there is no
existing TokenHandle. Existing users should all go through the
BackfillToken path. This would let the login screen code test against
existing TokenHandle rather than racing with FillForNewUser code.

BUG= 596502 

Review URL: https://codereview.chromium.org/1824693002

Cr-Commit-Position: refs/heads/master@{#382342}

[modify] https://crrev.com/9231ba274a1c6525bf06cfc1a214fae2967663b7/chrome/browser/chromeos/login/session/user_session_manager.cc

Labels: Merge-Request-50

Comment 11 by tin...@google.com, Mar 21 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 21 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43d3155e38ae1890b8776731c3fcffcb44ef46b6

commit 43d3155e38ae1890b8776731c3fcffcb44ef46b6
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Mon Mar 21 19:36:46 2016

Merge cros: Fix unexpected cryptohome failure UI

> TokenHandleFetcher::FillForNewUser should be called when there is no
> existing TokenHandle. Existing users should all go through the
> BackfillToken path. This would let the login screen code test against
> existing TokenHandle rather than racing with FillForNewUser code.
>
> BUG= 596502 
>
> Review URL: https://codereview.chromium.org/1824693002
>
> Cr-Commit-Position: refs/heads/master@{#382342}
> (cherry picked from commit 9231ba274a1c6525bf06cfc1a214fae2967663b7)

Review URL: https://codereview.chromium.org/1818823004 .

Cr-Commit-Position: refs/branch-heads/2661@{#323}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/43d3155e38ae1890b8776731c3fcffcb44ef46b6/chrome/browser/chromeos/login/session/user_session_manager.cc

Status: Fixed (was: Started)
Xiyuan@ can you please merge this to 50 beta too? Let me know if you need a merge approval.
#12 merged the CL to branch 2661. Is that where 50 beta is?
Cc: dhadd...@chromium.org
Components: Services>SignIn
Labels: VerifyIn-54

Comment 18 by ka...@chromium.org, Aug 31 2016

Labels: Bulk-Verified
Status: Verified (was: Fixed)

Sign in to add a comment