New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 596488 link

Starred by 2 users
Status: Fixed
Owner:
benwells@chromium.org
Closed: Apr 2016
Cc:
█ forg@chromium.org
maxwalker@chromium.org
█ owe...@chromium.org
█ egm@chromium.org
palmer@chromium.org
█ f...@chromium.org
█ rolfe@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Remove HTTPS from permission prompt UI strings (bubble on Desktop, infobar on mobile)

Project Member Reported by ainslie@chromium.org, Mar 21 2016 
Following up on the "Origin Presentation Question" email thread from last week/ 

Context: 
In some of our UIs today (ex: install banner), we show "example.com" instead of "https://example.com". The idea is that because only HTTPS sites can ask for these features, we don't need the extra https syntax in UI strings. 

Plan: 
For consistency and readability, we should extend this logic to cover the permissions prompt UIs (bubbles on desktop, infobars on mobile): 
- for HTTPS, remove the scheme
- for HTTP, show the scheme

Comment 1 by f...@chromium.org, Mar 26 2016

Owner: benwells@chromium.org
Status: Assigned (was: Unconfirmed)
ben, a fairly small permission bubble UI change

Comment 2 by f...@chromium.org, Mar 26 2016

Components: UI>Browser>Bubbles UI>Browser>Infobars

Comment 3 by benwells@chromium.org, Mar 30 2016

Status: Started (was: Assigned)
Interesting, looking at the code maybe we can catch a lot of things which show origins in one fell sweep.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2337b81057c1ac85098834ad75d250e7d87e6a39

commit 2337b81057c1ac85098834ad75d250e7d87e6a39
Author: benwells <benwells@chromium.org>
Date: Wed Apr 20 01:53:53 2016

Don't show scheme in permission prompts if it is HTTPS

HTTPS is nice and safe, so doesn't need to be called out in permission prompts. This change should also make origin display for permission prompts consistent across Android, Mac and Views.

BUG= 596488 

Review URL: https://codereview.chromium.org/1843063002

Cr-Commit-Position: refs/heads/master@{#388404}

[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/android/url_utilities.cc
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/download/notification/download_item_notification.cc
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/geolocation/geolocation_infobar_delegate_android.cc
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/geolocation/geolocation_infobar_delegate_android.h
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/media/media_stream_devices_controller.cc
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/media/media_stream_devices_controller.h
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/media/media_stream_infobar_delegate_android.cc
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/media/midi_permission_infobar_delegate_android.cc
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/media/midi_permission_infobar_delegate_android.h
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/media/protected_media_identifier_infobar_delegate_android.cc
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/media/protected_media_identifier_infobar_delegate_android.h
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/notifications/notification_permission_infobar_delegate.cc
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/notifications/notification_permission_infobar_delegate.h
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/permissions/permission_bubble_request_impl.cc
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/permissions/permission_infobar_delegate.cc
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/permissions/permission_infobar_delegate.h
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/push_messaging/push_messaging_notification_manager.cc
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/chrome/browser/ui/website_settings/website_settings.cc
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/components/app_modal/javascript_dialog_manager.cc
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/components/password_manager/core/browser/password_ui_utils.cc
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/components/password_manager/core/browser/password_ui_utils.h
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/components/url_formatter/elide_url.cc
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/components/url_formatter/elide_url.h
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/components/url_formatter/elide_url_unittest.cc
[modify] https://crrev.com/2337b81057c1ac85098834ad75d250e7d87e6a39/ui/message_center/views/notification_view.cc

Comment 5 by benwells@chromium.org, Apr 20 2016

Status: Fixed (was: Started)

Comment 6 by lafo...@chromium.org, Dec 9 2016

Components: -Security>UX
Labels: Team-Security-UX
Security>UX component is deprecated in favor of the Team-Security-UX label
►

Sign in to add a comment