Issue metadata
Sign in to add a comment
|
15.8% regression in startup.cold.blank_page at 381882:381888 |
||||||||||||||||||||
Issue descriptionLooks like a clear regression. I note this metric is pretty noisy, we'll have to see what the bisect finds.
,
Mar 21 2016
=== Auto-CCing suspected CL author yawano@chromium.org === Hi yawano@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Reland: Create hard links in file migration if necessary. Author : yawano Commit description: TBR=hashimoto@chromium.org Original CL: Create hard links in file migration if necessary. BUG= 533750 TEST=unit_tests:FileCacheTest.MigrateCacheFiles Committed: https://crrev.com/c5c297d58dc4d90423ed222f5bc7c06a84156324 Cr-Commit-Position: refs/heads/master@{#375836} patch from issue 1698793003 at patchset 20001 (http://crrev.com/1698793003#ps20001) Review URL: https://codereview.chromium.org/1811933004 Cr-Commit-Position: refs/heads/master@{#381888} Commit : cbe6dc8d336bcf5e8a9b0e7da7d5b0939bda32e6 Date : Fri Mar 18 04:56:06 2016 ===== TESTED REVISIONS ===== Revision Mean Value Std. Dev. Num Values Good? chromium@381881 5355.6 356.363999 5 good chromium@381885 5123.0 157.303846 5 good chromium@381887 5265.2 146.303452 5 good chromium@381888 4819.4 75.754868 5 bad Bisect job ran on: linux_perf_bisect Bug ID: 596478 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests startup.cold.blank_page Test Metric: foreground_tab_request_start/foreground_tab_request_start Relative Change: 10.01% Score: 98.0 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6326 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9017569959476747968 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with label Cr-Tests-AutoBisect. Thank you!
,
Mar 21 2016
Well that can't be right, the patch was reverted.
,
Mar 21 2016
=== Auto-CCing suspected CL author shuchen@chromium.org === Hi shuchen@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : UX updates for IME window. Author : shuchen Commit description: 1) The follow cursor window should NOT be auto shown when focusing to an input field. 2) The normal window should NOT show the extension's name on the title bar. BUG=517773 Review URL: https://codereview.chromium.org/1807133002 Cr-Commit-Position: refs/heads/master@{#381882} Commit : 53be152bb6639c0b0da94320af3d2a2d3acb0689 Date : Fri Mar 18 04:50:32 2016 ===== TESTED REVISIONS ===== Revision Mean Value Std. Dev. Num Values Good? chromium@381881 5069.666667 184.992547 12 good chromium@381882 6166.8 120.069563 5 bad chromium@381883 5705.2 84.140953 5 bad chromium@381885 5384.0 115.894348 5 bad chromium@381888 5192.222222 99.278903 18 bad Bisect job ran on: linux_perf_bisect Bug ID: 596478 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests startup.cold.blank_page Test Metric: foreground_tab_load_complete/foreground_tab_load_complete Relative Change: 0.83% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6325 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9017570179856734752 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with label Cr-Tests-AutoBisect. Thank you!
,
Mar 21 2016
I don't believe https://codereview.chromium.org/1807133002 caused a perf regression, it's deleting code not adding something new.
,
Mar 21 2016
=== Auto-CCing suspected CL author yawano@chromium.org === Hi yawano@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Revert of Reland: Create hard links in file migration if necessary. (patchset #1 id:1 of https://codereview.chromium.org/1811933004/ ) Author : yawano Commit description: Reason for revert: This CL broke buildbot. https://build.chromium.org/p/chromium/builders/Win/builds/41435 Original issue's description: > Reland: Create hard links in file migration if necessary. > > TBR=hashimoto@chromium.org > > Original CL: > Create hard links in file migration if necessary. > > BUG= 533750 > TEST=unit_tests:FileCacheTest.MigrateCacheFiles > > Committed: https://crrev.com/c5c297d58dc4d90423ed222f5bc7c06a84156324 > Cr-Commit-Position: refs/heads/master@{#375836} > > patch from issue 1698793003 at patchset 20001 (http://crrev.com/1698793003#ps20001) > > Committed: https://crrev.com/cbe6dc8d336bcf5e8a9b0e7da7d5b0939bda32e6 > Cr-Commit-Position: refs/heads/master@{#381888} TBR=hashimoto@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 533750 Review URL: https://codereview.chromium.org/1815053003 Cr-Commit-Position: refs/heads/master@{#381898} Commit : b3b718dbd360c8159ed62973b3bd10a99d67eabe Date : Fri Mar 18 06:15:37 2016 ===== TESTED REVISIONS ===== Revision Mean Value Std. Dev. Num Values Good? chromium@381800 6078.0 241.23329 5 good chromium@381845 6059.0 47.233463 5 good chromium@381874 6102.4 54.615016 5 good chromium@381887 6162.0 46.599356 5 good chromium@381894 6208.0 109.013761 5 good chromium@381897 6588.6 100.370812 5 good chromium@381898 5705.8 44.740362 5 bad chromium@381899 5489.8 40.690294 5 bad chromium@381900 5820.4 54.615016 5 bad Bisect job ran on: linux_perf_bisect Bug ID: 596478 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests startup.cold.blank_page Test Metric: foreground_tab_load_complete/foreground_tab_load_complete Relative Change: 4.24% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6328 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9017566456822138976 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with label Cr-Tests-AutoBisect. Thank you!
,
Mar 21 2016
=== Auto-CCing suspected CL author dpapad@chromium.org === Hi dpapad@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : MD Settings: Certificate manager, error dialog. Author : dpapad Commit description: BUG= 547073 Review URL: https://codereview.chromium.org/1812673002 Cr-Commit-Position: refs/heads/master@{#381884} Commit : 576dabdc2ea5abc890fb03822bc30c04b942aeec Date : Fri Mar 18 04:52:13 2016 ===== TESTED REVISIONS ===== Revision Mean Value Std. Dev. Num Values Good? chromium@381881 5176.75 204.590556 12 good chromium@381883 5142.4 75.675624 5 good chromium@381884 4911.8 58.712861 5 bad chromium@381885 4968.0 29.0 5 bad chromium@381888 5241.5 1014.332158 12 bad Bisect job ran on: linux_perf_bisect Bug ID: 596478 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests startup.cold.blank_page Test Metric: foreground_tab_load_complete/foreground_tab_load_complete Relative Change: 7.65% Score: 99.5 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6330 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9017565714292808656 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with label Cr-Tests-AutoBisect. Thank you!
,
Mar 21 2016
===== BISECT JOB RESULTS ===== Status: completed === Bisection aborted === The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression. Please contact the the team (see below) if you believe this is in error. === Warnings === The following warnings were raised by the bisect job: * Bisect failed to reproduce the regression with enough confidence. ===== TESTED REVISIONS ===== Revision Mean Value Std. Dev. Num Values Good? chromium@381881 5375.222222 292.371753 18 good chromium@381888 5377.611111 267.609931 18 bad Bisect job ran on: linux_perf_bisect Bug ID: 596478 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests startup.cold.blank_page Test Metric: foreground_tab_request_start/foreground_tab_request_start Relative Change: 0.76% Score: 0 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6329 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9017565709632568864 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with label Cr-Tests-AutoBisect. Thank you!
,
Mar 21 2016
I'm not convinced by the bisects here. I'm going to try again with a high repeat count.
,
Mar 21 2016
It looks like the ref build moved as well, so it might not be a real regression. Also consider expanding the commit range? The alert might be in the wrong place. Might go with 381845 as the last known good commit.
,
Mar 29 2016
Closing since the ref build moved as well. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by alexclarke@chromium.org
, Mar 21 2016