New issue
Advanced search Search tips

Issue 596475 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

12.2% regression in smoothness.gpu_rasterization.tough_path_rendering_cases at 382096:382111

Project Member Reported by alexclarke@chromium.org, Mar 21 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=596475

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgoPmnqwoM


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Mar 21 2016

Cc: ericrk@chromium.org
Owner: ericrk@chromium.org

=== Auto-CCing suspected CL author ericrk@chromium.org ===

Hi ericrk@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Add CONTEXT_TYPE_OPENGLES2_PEPPER
Author  : ericrk
Commit description:
  
Adds a new context type for Pepper GL contexts. This allows us to
fine tune driver bug workarounds for pepper vs. non-pepper contexts.

Currently used to disable the Intel MSAA blacklist on pepper contexts,
as it should be up to the app whether to use MSAA.

BUG= 527565 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1781093002

Cr-Commit-Position: refs/heads/master@{#382097}
Commit  : d72af43d432d9def9ce591b7167c19b7b1581e30
Date    : Fri Mar 18 21:45:56 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@382095         22.213712   0.088546    5           good
chromium@382096         22.127323   0.098416    5           good
chromium@382097         25.015998   0.097635    5           bad
chromium@382099         24.99135    0.067314    5           bad
chromium@382103         24.977093   0.175088    5           bad
chromium@382111         24.922334   0.047385    5           bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 596475

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests smoothness.gpu_rasterization.tough_path_rendering_cases
Test Metric: frame_times/http___ie.microsoft.com_testdrive_Performance_Chalkboard_
Relative Change: 12.19%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1217
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9017570269995133056


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 21 2016


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Add CONTEXT_TYPE_OPENGLES2_PEPPER
Author  : ericrk
Commit description:
  
Adds a new context type for Pepper GL contexts. This allows us to
fine tune driver bug workarounds for pepper vs. non-pepper contexts.

Currently used to disable the Intel MSAA blacklist on pepper contexts,
as it should be up to the app whether to use MSAA.

BUG= 527565 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1781093002

Cr-Commit-Position: refs/heads/master@{#382097}
Commit  : d72af43d432d9def9ce591b7167c19b7b1581e30
Date    : Fri Mar 18 21:45:56 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@382095         23.633159   0.116491    5           good
chromium@382096         23.587495   0.150918    5           good
chromium@382097         35.99625    0.126577    5           bad
chromium@382099         35.930028   0.093856    5           bad
chromium@382103         35.896394   0.063643    5           bad
chromium@382111         35.938455   0.223437    5           bad
chromium@382128         35.822077   0.124733    5           bad

Bisect job ran on: mac_10_11_perf_bisect
Bug ID: 596475

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests smoothness.gpu_rasterization.tough_path_rendering_cases
Test Metric: frame_times/frame_times
Relative Change: 51.58%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/547
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9017569467610323408


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!

Comment 4 by ericrk@chromium.org, Mar 22 2016

Status: Started (was: Assigned)
Fix in progress: crrev.com/1826673002
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a7b8ea49fe9b5d8509a9a43275809ab759853a8

commit 9a7b8ea49fe9b5d8509a9a43275809ab759853a8
Author: ericrk <ericrk@chromium.org>
Date: Wed Mar 23 18:03:06 2016

Add missing IPC struct member msaa_is_slow.

Missed this in previous CL: crrev.com/1781093002 - added this field to the capabilities, but not to the IPC struct traits.

Might explain some of the flakiness in GPU bots.

BUG= 596730 ,  596475 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1826673002

Cr-Commit-Position: refs/heads/master@{#382879}

[modify] https://crrev.com/9a7b8ea49fe9b5d8509a9a43275809ab759853a8/gpu/ipc/common/gpu_command_buffer_traits_multi.h

Comment 6 by ericrk@chromium.org, Mar 24 2016

Status: Fixed (was: Started)

Sign in to add a comment