New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 596471 link

Starred by 1 user
Status: Fixed
Owner:
█ harkness@chromium.org
Last visit > 30 days ago
Closed: Apr 2016
Cc:
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Push Messaging Browser tests should test subscription from ServiceWorkers

Project Member Reported by harkness@chromium.org, Mar 21 2016 

Current browser tests for Push API only tests subscribing from a document, because we didn't have the ability to subscribe from a worker without a manifest.

Now that an application specified key is available (https://codereview.chromium.org/1801113003/), we should add tests that have subscriptions from the service worker.

Tests should cover:
* Subscription by a worker without a key but with an available manifest
* Re-subscription by a worker without a key but where the info can be looked up
* Subscription by a worker with a valid key

Comment 1 by mvanouwe...@chromium.org, Mar 22 2016

Labels: -M-50 M-51
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a019912946921d445189c61af9c1ab5c3cef860

commit 2a019912946921d445189c61af9c1ab5c3cef860
Author: harkness <harkness@chromium.org>
Date: Thu Mar 31 18:15:24 2016

Add testing for subscription from service workers

Testing covers subscription from workers both with and without keys, and in
situations where it triggers a read from a manifest or a pre-subscribed worker.

This also cleaned up the unregistration, so that any registrations are searched
for, instead of using a variable to store the registration.

BUG= 596471 

Review URL: https://codereview.chromium.org/1816123002

Cr-Commit-Position: refs/heads/master@{#384332}

[modify] https://crrev.com/2a019912946921d445189c61af9c1ab5c3cef860/chrome/browser/push_messaging/push_messaging_browsertest.cc
[modify] https://crrev.com/2a019912946921d445189c61af9c1ab5c3cef860/chrome/browser/push_messaging/push_messaging_permission_context.cc
[modify] https://crrev.com/2a019912946921d445189c61af9c1ab5c3cef860/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc
[add] https://crrev.com/2a019912946921d445189c61af9c1ab5c3cef860/chrome/test/data/push_messaging/push_constants.js
[modify] https://crrev.com/2a019912946921d445189c61af9c1ab5c3cef860/chrome/test/data/push_messaging/push_test.js
[modify] https://crrev.com/2a019912946921d445189c61af9c1ab5c3cef860/chrome/test/data/push_messaging/service_worker.js
[modify] https://crrev.com/2a019912946921d445189c61af9c1ab5c3cef860/chrome/test/data/push_messaging/subscope1/test.html
[modify] https://crrev.com/2a019912946921d445189c61af9c1ab5c3cef860/chrome/test/data/push_messaging/subscope2/test.html
[modify] https://crrev.com/2a019912946921d445189c61af9c1ab5c3cef860/chrome/test/data/push_messaging/test.html
[modify] https://crrev.com/2a019912946921d445189c61af9c1ab5c3cef860/chrome/test/data/push_messaging/test_no_subscription_options.html
[modify] https://crrev.com/2a019912946921d445189c61af9c1ab5c3cef860/content/browser/push_messaging/push_messaging_message_filter.cc
[modify] https://crrev.com/2a019912946921d445189c61af9c1ab5c3cef860/content/child/push_messaging/push_provider.cc
[modify] https://crrev.com/2a019912946921d445189c61af9c1ab5c3cef860/content/renderer/push_messaging/push_messaging_dispatcher.cc
[modify] https://crrev.com/2a019912946921d445189c61af9c1ab5c3cef860/third_party/WebKit/Source/modules/push_messaging/PushManager.cpp
[modify] https://crrev.com/2a019912946921d445189c61af9c1ab5c3cef860/third_party/WebKit/Source/modules/push_messaging/PushManagerTest.cpp

Comment 3 by harkness@chromium.org, Apr 13 2016

Status: Fixed (was: Started)
►

Sign in to add a comment