New issue
Advanced search Search tips

Issue 596425 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

PHP behavior on Linux doesn't match Mac/Win

Project Member Reported by mkwst@chromium.org, Mar 21 2016

Issue description

In patchset #5 of https://codereview.chromium.org/1783813002, Linux bots fail, while Windows and Mac pass. After a bit of debugging, I think this is due to the latter bots supporting the `JSON_PRETTY_PRINT` argument to `json_encode`, which looks like it was added in version 5.5.0 of PHP.

Is it possible that our Linux bots have a different version of PHP than the other bots? If so, could we either upgrade them, or downgrade the others? :)

Thanks!
 

Comment 1 by mkwst@chromium.org, Apr 5 2016

And I just wasted quite a bit of time on the ~same issue in https://codereview.chromium.org/1844053003.

Comment 2 by mkwst@chromium.org, Apr 5 2016

Cc: serg...@chromium.org
Labels: Infra-Labs
Status: Untriaged (was: Unconfirmed)
sergiyb@ suggests "Infra-Labs" as a good label.
Cc: -serg...@chromium.org
I doubt I can help here short of suggesting the label :-). Labs team have their own triage and should reply here soon.

Comment 4 by jpar...@google.com, Apr 11 2016

Labels: -Infra
Bump to labs team ...

Comment 5 by fried...@google.com, Apr 11 2016

Owner: friedman@chromium.org
Status: Assigned (was: Untriaged)
I would expect none of our bots to have php installed.  This is surprising/alarming news to me.

Comment 6 by fried...@google.com, Apr 11 2016

Weird... I can't find any mention of php being installed in our kickstart scripts, or our linux setup.sh, or the puppet repo.

Does anyone know how this is getting installed?

Comment 7 by jo...@google.com, Apr 11 2016

Perhaps as a dependency from something in install-build-deps?

Comment 8 by fried...@google.com, Apr 11 2016

Ah, I forgot about that.  Thanks.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 11 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/16c00fc6638ff580d7e8a250f26b1cb0ba4991cd

commit 16c00fc6638ff580d7e8a250f26b1cb0ba4991cd
Author: Elliott Friedman <friedman@google.com>
Date: Mon Apr 11 23:02:06 2016

PHP should be updated by now.  Can you check again?
Status: Fixed (was: Assigned)
Components: Infra>Labs
Labels: -Infra-Labs
Labels: Test-Layout

Sign in to add a comment