New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 596423 link

Starred by 1 user
Status: Fixed
Owner:
shuchen@chromium.org
Closed: Mar 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Profile name is missing in avatar bubble of Supervised user.

Reported by vvishwak...@etouch.net, Mar 21 2016 
Version: 51.0.2686.0 (Official Build) b3fd89db02212a4c8cd3c9f19632a2b2e0fe1f68-refs/heads/master@{#382218} (32/64-bit)
OS: Linux, Windows(Win 7-Aero enabled)

What steps will reproduce the problem?
1) Launch chrome, Sign in to chrome and go to chrome://settings.
2) From People section, add/import a supervised user.
2) Switch to supervised user, click on avatar bubble and observe.

Profile name is missing in avatar bubble of Supervised user. 

Profile name should be seen in avatar bubble of Supervised user. 

This is a Regression issue broken in M-49, below is the bisect info

Manual bisect 
Good build: 49.0.2590.0
Bad build: 49.0.2591.0

Narrow bisect URL:
https://chromium.googlesource.com/chromium/src/+log/2bc4efa3e29a78afcc9e5d4b988ae7cb5081e979..2f21649234b0207dc131a31329934a741a111c84?pretty=fuller&n=100

Suspecting: r364943

Note: Issue is not seen on Mac OS.
supervised_actual.jpg
59.3 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee6ba2af8c8cc70e1b12d22e3e68a9244145a253

commit ee6ba2af8c8cc70e1b12d22e3e68a9244145a253
Author: shuchen <shuchen@chromium.org>
Date: Fri Mar 25 05:53:36 2016

Renders the profile name button in profile chooser view for supervised user.

BUG= 596423 

Review URL: https://codereview.chromium.org/1830903006

Cr-Commit-Position: refs/heads/master@{#383254}

[modify] https://crrev.com/ee6ba2af8c8cc70e1b12d22e3e68a9244145a253/chrome/browser/ui/views/profiles/profile_chooser_view.cc

Comment 2 by shuchen@chromium.org, Mar 29 2016

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73b0c4641caccf9783eb2d5b09b4019b92204343

commit 73b0c4641caccf9783eb2d5b09b4019b92204343
Author: shuchen <shuchen@chromium.org>
Date: Tue Mar 29 05:34:30 2016

Correctly layout the profile name button, and disable the button listener for supervised user.

BUG= 596423 

Review URL: https://codereview.chromium.org/1833383002

Cr-Commit-Position: refs/heads/master@{#383674}

[modify] https://crrev.com/73b0c4641caccf9783eb2d5b09b4019b92204343/chrome/browser/ui/views/profiles/profile_chooser_view.cc
►

Sign in to add a comment