New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596416 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 584352

Blocking:
issue 584303



Sign in to add a comment

[tracking bug] Implement snap point for Zine NTP

Project Member Reported by maybelle@chromium.org, Mar 21 2016

Issue description

The motion spec (https://folio.googleplex.com/chrome-ux/mocks/335-NTP-Zine/Motion/transition#%2FZine-transition-780.mov%3Fz=width) specifies a snap point to the first Zine card. Make sure that the old snap points on the old NTP are preserved when Zine feature is off.

This depends on https://codereview.chromium.org/1812293002/ landing.
 
Blockedon: 584352
Cc: maybelle@chromium.org
Owner: peconn@chromium.org
I'd like to add that UX has made the decision to only have 1 snap point for the Zine NTP, so don't need the intermediary snap to ML. I don't think this was widely advertised.

Comment 4 by peconn@chromium.org, Apr 14 2016

Status: Started (was: Assigned)

Comment 5 by peconn@chromium.org, Apr 14 2016

Labels: zine-mr-iter-10

Comment 6 by peconn@chromium.org, Apr 14 2016

Components: UI>Browser>NewTabPage

Comment 7 by fi...@chromium.org, Apr 15 2016

Comment from Rachel: In the case where there aren't enough snippets to fully transition the top bar, we should probably add some more background at the bottom. There should be a shadow on the bottom edge of the card as well.  

Comment 8 by peconn@chromium.org, Apr 15 2016

Labels: zine-mr-iter-11
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4a2b825f7517623ae026660f81ce96eb965d46f

commit e4a2b825f7517623ae026660f81ce96eb965d46f
Author: peconn <peconn@chromium.org>
Date: Mon Apr 18 09:44:54 2016

Implement snap scrolling for Zine NTP.

Use absolute coordinates to smooth scroll to either the top of the NTP or to the top of the articles view.

Additionally, removed NewTabPageRecyclerView.OnScrollListener and related functionality, since NewTabPageRecyclerView inherits that behaviour from RecyclerView.

BUG= 596416 

Review URL: https://codereview.chromium.org/1884883004

Cr-Commit-Position: refs/heads/master@{#387880}

[modify] https://crrev.com/e4a2b825f7517623ae026660f81ce96eb965d46f/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[modify] https://crrev.com/e4a2b825f7517623ae026660f81ce96eb965d46f/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

Status: Fixed (was: Started)

Sign in to add a comment