[tracking bug] Add favicon and publisher canonical name to cards |
||||||||||||||||
Issue descriptionCards don't have the favicon and publisher name on the cards. We also need to account for situations when this data is not available, and have a default. For favicons specifically we can fall back to our favicon fetching service and otherwise have a static drawable. Talk to maybelle@ or rachelis@ to get this drawable.
,
Mar 21 2016
,
Mar 22 2016
NTPSnippets.cc also needs to be updated to parse the publisher name and favicon. In the json, it looks like: "sourceName": "Los Angeles Times", "sourceLogoUrl": ""
,
Apr 1 2016
,
Apr 4 2016
Patrick, any update on the requirements for this regarding permissions to use this data. Thanks
,
Apr 4 2016
,
Apr 6 2016
In the case of ChromeReader not having favicons, we should anyway fall back to our own favicon service so I think it's still worth doing that piece while we wait for decision on using ChromeReader's data.
,
Apr 7 2016
,
Apr 7 2016
,
Apr 8 2016
Code is almost ready for review, but may spill over into next week.
,
Apr 14 2016
Ran into complications with actually getting usable favicons. Still talking to the relevant teams to see if we can use a different Google service to fetch the favicon.
,
Apr 21 2016
Issue 605235 has been merged into this issue.
,
Apr 22 2016
Clean-up - obviously an MVP P1.
,
Apr 22 2016
Writing tests today, part I (without downloading the favicons from an external source) will be in CR shortly.
,
Apr 28 2016
,
Apr 28 2016
In CR now
,
May 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7360bf8adcd2455a07dbf39f41f33b6bc194899 commit f7360bf8adcd2455a07dbf39f41f33b6bc194899 Author: maybelle <maybelle@chromium.org> Date: Wed May 04 13:31:02 2016 Add favicon and publisher name to snippet cards BUG= 596410 Review-Url: https://codereview.chromium.org/1921553004 Cr-Commit-Position: refs/heads/master@{#391493} [modify] https://crrev.com/f7360bf8adcd2455a07dbf39f41f33b6bc194899/chrome/android/java/res/layout/new_tab_page_snippets_card.xml [modify] https://crrev.com/f7360bf8adcd2455a07dbf39f41f33b6bc194899/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java [modify] https://crrev.com/f7360bf8adcd2455a07dbf39f41f33b6bc194899/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java [modify] https://crrev.com/f7360bf8adcd2455a07dbf39f41f33b6bc194899/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java [modify] https://crrev.com/f7360bf8adcd2455a07dbf39f41f33b6bc194899/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/f7360bf8adcd2455a07dbf39f41f33b6bc194899/chrome/browser/android/ntp/ntp_snippets_bridge.cc [modify] https://crrev.com/f7360bf8adcd2455a07dbf39f41f33b6bc194899/chrome/browser/ui/webui/snippets_internals_message_handler.cc [modify] https://crrev.com/f7360bf8adcd2455a07dbf39f41f33b6bc194899/components/ntp_snippets/ntp_snippet.cc [modify] https://crrev.com/f7360bf8adcd2455a07dbf39f41f33b6bc194899/components/ntp_snippets/ntp_snippet.h [modify] https://crrev.com/f7360bf8adcd2455a07dbf39f41f33b6bc194899/components/ntp_snippets/ntp_snippets_service.cc [modify] https://crrev.com/f7360bf8adcd2455a07dbf39f41f33b6bc194899/components/ntp_snippets/ntp_snippets_service_unittest.cc [modify] https://crrev.com/f7360bf8adcd2455a07dbf39f41f33b6bc194899/components/ntp_snippets/switches.cc [modify] https://crrev.com/f7360bf8adcd2455a07dbf39f41f33b6bc194899/components/ntp_snippets/switches.h [modify] https://crrev.com/f7360bf8adcd2455a07dbf39f41f33b6bc194899/tools/metrics/histograms/histograms.xml
,
May 4 2016
,
Jul 1 2016
,
Jul 1 2016
,
Jul 1 2016
|
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by maybelle@chromium.org
, Mar 21 2016Owner: mcwilliams@chromium.org