New issue
Advanced search Search tips

Issue 596387 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Flaky compile: Cannot open include file: 'ui/gfx/vector_icons.h': No such file or directory

Project Member Reported by phoglund@chromium.org, Mar 21 2016

Issue description

Version: 
OS: Win

What is the expected output? What do you see instead?
This compile error happened flakily and closed the tree, without any relation to the CL that triggered the build. ui/gfx/vector_icons.h is generated by https://code.google.com/p/chromium/codesearch#chromium/src/ui/gfx/vector_icons/aggregate_vector_icons.py&q=vector_icons.h.template&sq=package:chromium&type=cs, and I would guess https://code.google.com/p/chromium/codesearch#chromium/src/components/toolbar/test_toolbar_model.cc&sq=package:chromium&type=cs&q=test_toolbar_model.cc&l=1 does not properly depend on the generated header.

https://build.chromium.org/p/chromium/builders/Win/builds/41515/steps/compile/logs/stdio:

[10395/32767] CXX obj\ui\events\test\events_test_support.platform_event_source_test_api.obj
FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs_files\a3796183a9fc4d22a687c5212b9c76dbd136d70d\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\components\toolbar\toolbar_test_support.test_toolbar_model.obj.rsp /c ..\..\components\toolbar\test_toolbar_model.cc /Foobj\components\toolbar\toolbar_test_support.test_toolbar_model.obj /Fdobj\components\toolbar_test_support.cc.pdb 
c:\b\build\slave\win\build\src\ui\gfx\vector_icons_public.h(11): fatal error C1083: Cannot open include file: 'ui/gfx/vector_icons.h': No such file or directory
ninja: build stopped: subcommand failed.
[10395/32767] CXX obj\ui\events\test\events_test_support.platform_event_source_test_api.obj
FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs_files\a3796183a9fc4d22a687c5212b9c76dbd136d70d\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\components\toolbar\toolbar_test_support.test_toolbar_model.obj.rsp /c ..\..\components\toolbar\test_toolbar_model.cc /Foobj\components\toolbar\toolbar_test_support.test_toolbar_model.obj /Fdobj\components\toolbar_test_support.cc.pdb 
c:\b\build\slave\win\build\src\ui\gfx\vector_icons_public.h(11): fatal error C1083: Cannot open include file: 'ui/gfx/vector_icons.h': No such file or directory
ninja: build stopped: subcommand failed.

Please use labels and text to provide additional information.

 
pkasting, please help with an owner.

GN equivalent of this bug (?): https://bugs.chromium.org/p/chromium/issues/detail?id=535386.

Comment 2 by est...@chromium.org, Mar 21 2016

Cc: -est...@chromium.org pkasting@chromium.org
Owner: est...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6238b2033e0c7ffd6b0996ba42b60f39380ecd96

commit 6238b2033e0c7ffd6b0996ba42b60f39380ecd96
Author: estade <estade@chromium.org>
Date: Tue Mar 22 03:32:40 2016

Add vector icon dependency to components/toolbar

BUG= 596387 
TBR=blundell@chromium.org

Review URL: https://codereview.chromium.org/1823763002

Cr-Commit-Position: refs/heads/master@{#382499}

[modify] https://crrev.com/6238b2033e0c7ffd6b0996ba42b60f39380ecd96/components/toolbar.gypi

Comment 4 by est...@chromium.org, Mar 23 2016

Status: Fixed (was: Started)

Sign in to add a comment