Regression:[Devtools] The shape of the manual breakpoint indicator is not similar to that of the 'deactivate breakpoints' button on the sidebar. |
||||||
Issue descriptionChrome Version : 51.0.2686.0 (Official Build) OS Version : Ubuntu 14.04 What steps will reproduce the problem? (1)Launch chrome and open Devtools on any page. (2)Open sources tab and open any java script file. (3)Click on any line number to set a breakpoint and observe the blue color indicator. What is the expected result? The shape of the manual breakpoint indicator should be similar to the one on the sidebar. What happens instead? The shape of the manual breakpoint indicator is not similar to the design of the 'deactivate breakpoints' button on the sidebar. This is a regression issue broken in M-51.
,
Mar 21 2016
Able to reproduce the issue on windows 7, Mac 10.11.3 using chrome version 51.0.2686.0
,
Mar 21 2016
Dear Friend Thanks for the report, I'm on it to fix it. By the looks of it, the css is missing defining the border style and the fix should be an one liner. Adenilson
,
Mar 21 2016
,
Mar 21 2016
cavalcantii@, thank you! Sorry I didn't find this case when I did a quick grep of the code for usage of border-image, curious to know why this didn't show up!
,
Mar 21 2016
I wonder if there are devtools versioning implications here - eg. when using a new client to remote debug an older target (the front-end is version-matched to the target version).
,
Mar 21 2016
@rbyers: there certainly are - things should not stop working for people :)
,
Mar 22 2016
Uploaded a patch fixing it on: https://codereview.chromium.org/1818263002/
,
Mar 24 2016
This was fixed in master by: https://codereview.chromium.org/1822653004
,
Mar 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a767dd5e090318016add91a610ca807cf9eef25e commit a767dd5e090318016add91a610ca807cf9eef25e Author: cavalcantii <cavalcantii@chromium.org> Date: Thu Mar 24 18:53:51 2016 Handle the case for older releases (pre M51) by adding CSS fixes in compatibility script to handle the case of a border-image element that lacks the border-style. This fixes the case of broken inspector breakpoints. BUG= 596374 Review URL: https://codereview.chromium.org/1818263002 Cr-Commit-Position: refs/heads/master@{#383108} [modify] https://crrev.com/a767dd5e090318016add91a610ca807cf9eef25e/third_party/WebKit/Source/devtools/front_end/devtools.js
,
Mar 24 2016
This later patch will handle the case of using a newer browser (M51) to remote an older target (<M51).
,
Mar 24 2016
Someone that has the rights could update the bug status to Fixed?
,
Mar 24 2016
,
Apr 1 2016
,
Apr 1 2016
Note that the main fix for this was in this CL: https://chromium.googlesource.com/chromium/src/+/e641bea7d50b6d3d059154eb6a1eb49b42c5314b DevTools: fix breakpoints rendering As of the crrev.com/1815043003, the rules for rendring border-image css properties have changed. This affected the breakpoint rendering in the Sources panel. BUG=none R=dgozman, pfeldman Review URL: https://codereview.chromium.org/1822653004 Cr-Commit-Position: refs/heads/master@{#382484} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by radhakri...@techmahindra.com
, Mar 21 2016Owner: cavalcantii@chromium.org
Status: Assigned (was: Unconfirmed)