Issue metadata
Sign in to add a comment
|
Regression: Print preview crashes on rotating clockwise/counterclockwise.
Reported by
lpa...@etouch.net,
Mar 21 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 51.0.2686.0 (Official Build) b3fd89db02212a4c8cd3c9f19632a2b2e0fe1f68-refs/heads/master@{#382218} 32/64 Bit. OS: Windows (Win 7 Aero-Enabled) Steps: 1. Launch chrome and navigate to https://plus.google.com/+Chrome 2. Give print command (Ctrl+P) on the web >> Right click and select Rotate clockwise/counterclockwise. 3. Observe. Actual: Print preview crashes. Expected: Print preview should not crash, instead pages should rotate clockwise/counterclockwise. This is a regression issue broken in M-51, will soon update the other info.
,
Mar 21 2016
Crash ID: d6f06fe800000000 Stack trace for the crash ID generated: CRASHED [EXC_BAD_ACCESS / KERN_INVALID_ADDRESS @ 0x00000096 ] MAGIC SIGNATURE THREAD 0x000000010278d770 (Google Chrome Framework -pdfium_page.h:88 ) chrome_pdf::PDFiumEngine::LoadPageInfo(bool) 0x0000000102793631 (Google Chrome Framework -pdfium_engine.cc:2154 ) chrome_pdf::PDFiumEngine::InvalidateAllPages() 0x0000000102793526 (Google Chrome Framework -pdfium_engine.cc:3321 ) chrome_pdf::PDFiumEngine::RotateInternal() 0x000000010278551d (Google Chrome Framework -out_of_process_instance.cc:1170 ) chrome_pdf::(anonymous namespace)::Transform(int, PP_PrivatePageTransformType) 0x0000000106d1ba14 (Google Chrome Framework -proxy_lock.h:135 ) ppapi::proxy::PPP_Pdf_Proxy::OnMessageReceived(IPC::Message const&) 0x0000000106cd84e3 (Google Chrome Framework -dispatcher.cc:70 ) ppapi::proxy::Dispatcher::OnMessageReceived(IPC::Message const&) 0x0000000106cf7faf (Google Chrome Framework -plugin_dispatcher.cc:252 ) ppapi::proxy::PluginDispatcher::OnMessageReceived(IPC::Message const&) 0x0000000103244e57 (Google Chrome Framework -ipc_channel_proxy.cc:293 ) IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) 0x00000001027c242a (Google Chrome Framework -callback.h:397 ) base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask const&) 0x00000001027e4a12 (Google Chrome Framework -message_loop.cc:476 ) base::MessageLoop::RunTask(base::PendingTask const&) 0x00000001027e4ceb (Google Chrome Framework -message_loop.cc:485 ) base::MessageLoop::DeferOrRunPendingTask(base::PendingTask const&) 0x00000001027e4eda (Google Chrome Framework -message_loop.cc:597 ) base::MessageLoop::DoWork() 0x00000001027b7900 (Google Chrome Framework -message_pump_mac.mm:330 ) base::MessagePumpCFRunLoopBase::RunWork() 0x00000001027da1e9 (Google Chrome Framework + 0x005671e9 ) base::mac::CallWithEHFrame(void () block_pointer) 0x00000001027b7303 (Google Chrome Framework -message_pump_mac.mm:306 ) base::MessagePumpCFRunLoopBase::RunWorkSource(void*) 0x00007fff9ab355c0 (CoreFoundation + 0x0007e5c0 ) __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 0x00007fff9ab2741b (CoreFoundation + 0x0007041b ) __CFRunLoopDoSources0 0x00007fff9ab2693e (CoreFoundation + 0x0006f93e ) __CFRunLoopRun 0x00007fff9ab26337 (CoreFoundation + 0x0006f337 ) CFRunLoopRunSpecific 0x00000001027b7cce (Google Chrome Framework -message_pump_mac.mm:554 ) base::MessagePumpCFRunLoop::DoRun(base::MessagePump::Delegate*) 0x00000001027b7753 (Google Chrome Framework -message_pump_mac.mm:238 ) base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) 0x00000001027fb022 (Google Chrome Framework -run_loop.cc:35 ) base::RunLoop::Run() 0x00000001027e41bc (Google Chrome Framework -message_loop.cc:293 ) base::MessageLoop::Run() 0x000000010277143e (Google Chrome Framework -ppapi_plugin_main.cc:160 ) content::PpapiPluginMain(content::MainFunctionParams const&) 0x0000000102779013 (Google Chrome Framework -content_main_runner.cc:772 ) content::ContentMainRunnerImpl::Run() 0x0000000102778585 (Google Chrome Framework -content_main.cc:19 ) content::ContentMain(content::ContentMainParams const&) 0x0000000102275a91 (Google Chrome Framework -chrome_main.cc:84 ) ChromeMain 0x000000010200cd51 (Google Chrome Helper -chrome_exe_main_mac.c:87 ) main 0x000000010200cb33 (Google Chrome Helper + 0x00000b33 ) start Adding release block label, please undo if not the case.
,
Mar 21 2016
tsepez@ Please have a fix or revert soon. We are planning to cut Dev candidate by 8.00pm today.
,
Mar 21 2016
Looks to be an XFA issue. Will revert again while investigating.
,
Mar 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70d0e74ecba95f88cb7cfaf66a8a6d6a640267ed commit 70d0e74ecba95f88cb7cfaf66a8a6d6a640267ed Author: tsepez <tsepez@chromium.org> Date: Mon Mar 21 19:40:28 2016 Revert "Re-land: Enable XFA-Forms for the PDFium plugin." This reverts commit ed07b3773e3aad4a44a79a48c17162ef57ca82ee. Reason for revert: crbug.com/596373 . BUG= 596373 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1821763002 Cr-Commit-Position: refs/heads/master@{#382356} [modify] https://crrev.com/70d0e74ecba95f88cb7cfaf66a8a6d6a640267ed/build/common.gypi
,
Mar 22 2016
Verified the revert on Windows-7 and Mac OS 10.11.3 , latest canary(51.0.2687.0-master@{#382459}). This is working as intended and there is no crash observed on rotating the image clockwise/counterclockwise.
,
Mar 22 2016
,
Apr 21 2016
,
Apr 21 2016
,
Apr 21 2016
,
Apr 25 2016
It looks like the number of pages in the FPDF_DOCUMENT is getting confused. If you print the page there are 4 pages rendered. If you rotate the document, we attempt to get the page_ information for 7 pages. Need to determine why we've got 3 more pages then we should ....
,
Apr 25 2016
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium.git/+/1f5f2fff688f4075a62c87a032c9a9070bde89fc commit 1f5f2fff688f4075a62c87a032c9a9070bde89fc Author: dsinclair <dsinclair@chromium.org> Date: Mon Apr 25 21:14:56 2016 Fixup page removal for XFA documents. Currently when you call DelegePage on a CPDFXFA_Document the page will not be correctly removed. The page is left in the underlying document and, if GetPage was never called for that page index nothing will happen. This CL updates the code to always remove the page_index from the underlying CPDF_Document then, if needed, the original code runs to clear out the XFA page list for that page. BUG= chromium:596373 Review URL: https://codereview.chromium.org/1921033003 [modify] https://crrev.com/1f5f2fff688f4075a62c87a032c9a9070bde89fc/fpdfsdk/fpdfdoc_embeddertest.cpp [modify] https://crrev.com/1f5f2fff688f4075a62c87a032c9a9070bde89fc/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp
,
Apr 26 2016
Fixed, will roll DEPS before enabling XFA again.
,
Apr 26 2016
DEPS has been rolled. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by lpa...@etouch.net
, Mar 21 2016Owner: tsepez@chromium.org
Status: Assigned (was: Unconfirmed)