Issue metadata
Sign in to add a comment
|
[Regression]: Weird behavior of bookmark bar is seen after adding theme |
||||||||||||||||||||||||
Issue descriptionVersion: 51.0.2686.0 dev OS: Ubuntu 12.04,14.04 Test URL: https://chrome.google.com/webstore/detail/dog-zastavkifreeru/hcganoocidnpoebkmkcofebigochmmpo?hl=en What steps will reproduce the problem? (1) Launch chrome and add above theme (2) Open NTP and observe bookmark bar Expected: Content should be clear in bookmark bar Actual: Instead overlapping of text and weird bookmark bar is seen. This is a regression issue broken in M51. Will provide bisect info soon.
,
Mar 21 2016
CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/905b111f901585bd25901e72b2141a7dc4bae246..69da898ef90feb49e414476934abf708ed04c093 Suspecting https://codereview.chromium.org/1815743002 from changelog. @estade:Please help in re-assigning if it is not related to your change. NOTE: Issue is not seen in Windows.
,
Mar 21 2016
Confirming this issue able to repro only on Ubuntu 14.04 using chrome latest Dev M51-51.0.2686.0. Issue not seen on Mac OS 10.11.3 as well.
,
Mar 21 2016
Good Build: 51.0.2683.0 dev Bad Build: 51.0.2684.0 dev
,
Mar 21 2016
,
Mar 22 2016
Checked the issue on 51.0.2687.0 and is still reproducible. UI of bookmark bar is not as expected[Some painting effect is still seen]. Attaching screencast of same. This issue got duplicated into Issue 595978 which got fixed with commit position Cr-Commit-Position: refs/heads/master@{#382079} Latest build[51.0.2687.0] commit position is 382459 which is greater than fixed bug commit position 382079 and issue is still reproducible. Hence reopening the issue. @estade: Please feel free to change the status if any. Thanks!
,
Mar 22 2016
,
Mar 24 2016
estade@: Can we get an update on this issue as this issue is still seen as per C#6. Thank you!
,
Mar 30 2016
@estade: Hey, would you mind providing an update on the above issue as it is reproducible on Ubuntu 14.04 with chrome version '51.0.2693.2'. Appreciate your response. Thank you!
,
Apr 4 2016
Issue still persists on latest 51.0.2699.0.
,
Apr 5 2016
@estade: Request you to please take a look into it as issue still exists on M51 Canary 51.0.2699.0 on Linux OS. Issue is marked with a beta blocker and M51 is approaching Beta soon.
,
Apr 5 2016
,
Apr 5 2016
can you check to see if this is a problem on m50 on chromeos?
,
Apr 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/046ca0c1fd8e435ee0b15a5a84f517f0a3ca2da8 commit 046ca0c1fd8e435ee0b15a5a84f517f0a3ca2da8 Author: estade <estade@chromium.org> Date: Thu Apr 07 22:05:59 2016 Make sure to fill canvas opaquely when painting bookmark bar background. BUG= 596370 Review URL: https://codereview.chromium.org/1861783002 Cr-Commit-Position: refs/heads/master@{#385892} [modify] https://crrev.com/046ca0c1fd8e435ee0b15a5a84f517f0a3ca2da8/chrome/browser/ui/views/frame/browser_view.cc
,
Apr 7 2016
Reproduce the issue on Chrome 50.0.2661.67/ CrOS 7978.48.0 nyan_blaze
,
Apr 7 2016
Seen on crOS Beta Build 7978.48.0/50.0.2661.67 - Parrot Device as well.
,
Apr 7 2016
This is a low risk change. Requesting merge to m50. Note that it affects an unknown number of custom themes, but seemingly not very many of them.
,
Apr 7 2016
Adding "Merge-Request-50" label based on comment #17.
,
Apr 7 2016
Merge approved for M50 (branch 2661). Please merge your change by 5:00 PM PST on April 8th,Friday to make into the desktop Stable final build cut. Thank you.
,
Apr 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55427ea57b47260d67c83d166a7917f9bdb36dc0 commit 55427ea57b47260d67c83d166a7917f9bdb36dc0 Author: Evan Stade <estade@chromium.org> Date: Thu Apr 07 23:20:20 2016 Make sure to fill canvas opaquely when painting bookmark bar background. BUG= 596370 Review URL: https://codereview.chromium.org/1861783002 Cr-Commit-Position: refs/heads/master@{#385892} (cherry picked from commit 046ca0c1fd8e435ee0b15a5a84f517f0a3ca2da8) Review URL: https://codereview.chromium.org/1871793002 . Cr-Commit-Position: refs/branch-heads/2661@{#516} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/55427ea57b47260d67c83d166a7917f9bdb36dc0/chrome/browser/ui/views/frame/browser_view.cc
,
Apr 8 2016
,
Apr 13 2016
Verified the issue on Ubuntu 14.04 using Beta # 50.0.2661.75 and its working fine.Please find the attached screen shot for the same.
,
Jan 9 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by sc00335...@techmahindra.com
, Mar 21 2016