New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596285 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Thumbnails sites are not displayed when you change a search engine.

Reported by vzm...@gmail.com, Mar 19 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.87 Safari/537.36

Steps to reproduce the problem:
1. Change search engine to a different Google
2. Open a new page
3. Thumbnails turn into a white square

What is the expected behavior?
Thumbnails are displayed correctly, the links work.

What went wrong?
Thumbnails are not displayed

Did this work before? No 

Chrome version: 49.0.2623.87  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 21.0 r0
 
chrome_2016-03-20_00-22-00.png
86.5 KB View Download
chrome_2016-03-20_00-22-42.png
12.3 KB View Download

Comment 1 by shrike@chromium.org, Apr 27 2016

 Issue 605939  has been merged into this issue.
Created change request - https://codereview.chromium.org/1915513002

Comment 3 by treib@chromium.org, May 4 2016

Components: -UI UI>Browser>NewTabPage
Labels: OS-Chrome OS-Linux OS-Mac
Status: Available (was: Unconfirmed)
Project Member

Comment 4 by bugdroid1@chromium.org, May 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e18fcb44299b1d344a0d25a418e76e37596ccb26

commit e18fcb44299b1d344a0d25a418e76e37596ccb26
Author: a-v-y <a-v-y@yandex-team.ru>
Date: Mon May 09 19:41:01 2016

Fixed invalid parameter used by most visited thumbnail.

After https://codereview.chromium.org/1260113002 most visited sites
thumbnails on non Google newtab page are displayed incorrectly.
I beleive that the cause of this is rename of parameter "thumbnailUrl"
to "thumbnailUrls" in searchbox_extension.cc. I tried to
implement simple fix for it.

BUG= 596285 

R=fserb@chromium.org, huangs@chromium.org

Review-Url: https://codereview.chromium.org/1915513002
Cr-Commit-Position: refs/heads/master@{#392401}

[modify] https://crrev.com/e18fcb44299b1d344a0d25a418e76e37596ccb26/chrome/browser/resources/local_ntp/most_visited_thumbnail.js

I beleive this bug is fixed and can be closed.

Comment 6 by treib@chromium.org, Oct 4 2016

Cc: treib@chromium.org
Status: Fixed (was: Available)
Indeed, thanks!

Sign in to add a comment