User manager after child lock focuses on a wrong pod
Reported by
lwc...@gmail.com,
Mar 19 2016
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0 Steps to reproduce the problem: 1. Start chromium. 2. Create a user (existing users are okay). Name the user "?abc". 3. Create another user. Make it signed in. Name the user "#abc". 4. In user "#abc", click avatar menu at the top-right corner. Select "Exit and childlock". What is the expected behavior? The user pod "#abc" is focused. What went wrong? The user pod "?abc" is focused instead. Note: if your installation contains more than two profiles, the result can be different. Did this work before? Yes Before https://crrev.com/376977 . Sorry that's my own commit. Chrome version: M50 Channel: n/a OS Version: 10.0 Flash Version: Since I don't have the right myself, please help me to do the following: 1. assign to anthonyvd@ or rogerta@. 2. c.c. anthonyvd@, rogerta@, and mlerman@. 3. check if this blocks M50 stable. (Note: for English version, a special symbol in the username is required to trigger the bug. For CJK languages, it should be much easier.)
,
Mar 29 2016
,
Mar 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c91db6cc7f37dd9d28c539a437423834fa058d10 commit c91db6cc7f37dd9d28c539a437423834fa058d10 Author: lwchkg <lwchkg@gmail.com> Date: Thu Mar 31 18:26:49 2016 Profile path is sent instead of the index to focus a user pod Currently the index in ProfileInfoCache is sent to chrome://user-manager to initially select the user pod when we use "Exit and childlock" function. This was a fragile implementation, and unfortunately led to a bug (596280) when SendUserList in user_manager_screen_handler.cc sent the user list in a different order. Now a profile path, which does not depend on any order, is sent instead. BUG= 596280 Review URL: https://codereview.chromium.org/1828143002 Cr-Commit-Position: refs/heads/master@{#384339} [modify] https://crrev.com/c91db6cc7f37dd9d28c539a437423834fa058d10/chrome/browser/profiles/profile_window.cc [modify] https://crrev.com/c91db6cc7f37dd9d28c539a437423834fa058d10/chrome/browser/profiles/profile_window_browsertest.cc [add] https://crrev.com/c91db6cc7f37dd9d28c539a437423834fa058d10/chrome/test/data/webui/profile_window_browsertest.js [modify] https://crrev.com/c91db6cc7f37dd9d28c539a437423834fa058d10/ui/login/account_picker/user_pod_row.js
,
Mar 31 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mlerman@chromium.org
, Mar 29 2016Components: -UI UI>Browser>Profiles
Labels: OS-Linux OS-Mac
Owner: anthonyvd@chromium.org