Tautologous DCHECK in JSONParser implementation |
||
Issue descriptionReplacing DCHECK_OP()'s implementation with DCHECK((val1) op (val2)) in a debug build gives compilation error in base::JSONParser: https://code.google.com/p/chromium/codesearch#chromium/src/base/json/json_parser.cc&sq=package:chromium&l=312 void JSONParser::StringBuilder::Append(const char& c) { DCHECK_GE(c, 0); -> DCHECK_LT(c, 128); ... Since |c| is unsigned its range is -128 to 127; it seems that there should either be just the DCHECK_GE, or for better readability, just a DCHECK_LT(static_cast<unsigned char>(c), ...)?
,
Mar 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19c6150642d7ab6a5a455b36b85efd6715028425 commit 19c6150642d7ab6a5a455b36b85efd6715028425 Author: rsesek <rsesek@chromium.org> Date: Fri Mar 25 18:26:03 2016 Fix tautologous DCHECK in base::internal::JSONParser. BUG= 596278 R=mark@chromium.org Review URL: https://codereview.chromium.org/1834933003 Cr-Commit-Position: refs/heads/master@{#383316} [modify] https://crrev.com/19c6150642d7ab6a5a455b36b85efd6715028425/base/json/json_parser.cc
,
Mar 25 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by rsesek@chromium.org
, Mar 25 2016