New issue
Advanced search Search tips

Issue 596249 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Commit queue dry-runs should not pollute codereview message list.

Project Member Reported by scheib@chromium.org, Mar 19 2016

Issue description

See attached image. Dry runs should not create messages that obfuscate human review comments on patches.
 
code-review-messages.PNG
50.0 KB View Download
Cc: tandrii@chromium.org
Components: -Build
Labels: -Build-CommitQueue Infra-CommitQueue
We already have auto-generated and human comments with the ability to show/hide auto-generated comments. Perhaps we can also add a concept of bot comments and allow to show/hide them. WDYT?

OTH, we may choose to implement this feature in Gerrit instead. Andrii, how long do you think till the time when we can start using Gerrit as an opt-in for Chromium? 
Cc: serg...@chromium.org
Labels: -Type-Bug Type-Feature
So, the good thing is that people really like to use Dry Runs :) 
The is feature request, and it can be done entirely in Rietveld, if necessary CQ can post extra flag for Dry-run-induced messages.

As for Gerrit, I am certainly sure that review+try/CQ+land for chromium would be possible before end of Q2.
Status: Available (was: Untriaged)
Tags will allow the filtering of these messages in the near future: https://gerrit-review.googlesource.com/75803/

Comment 6 by aga...@chromium.org, Apr 26 2016

Components: Infra>CQ
Labels: -Infra-CommitQueue

Comment 7 by aga...@chromium.org, Apr 27 2016

Components: Infra>Codereview
Labels: -Infra-Codereview
Components: -Infra>Codereview Infra>Codereview>Rietveld
Owner: tandrii@chromium.org
Status: Started (was: Available)
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/452eb59a3572da8c5fa8656e0efdb4d2e1a5ead4

commit 452eb59a3572da8c5fa8656e0efdb4d2e1a5ead4
Author: tandrii <tandrii@google.com>
Date: Thu Jul 07 16:18:22 2016

Finally, display CQ status url next to commit box
And related issue to stop sending all emails whatsoever on CQ Dry run  http://crbug.com/626427 
Cc: -serg...@chromium.org
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/c346a10e53866da6d877268a234475ed603fde63

commit c346a10e53866da6d877268a234475ed603fde63
Author: tandrii <tandrii@google.com>
Date: Fri Jul 08 12:02:14 2016

Status: Fixed (was: Started)
This has been fixed and deployed. I didn't touch old CQ Dry run messages, as I think it's not worth the effort. However, if there is high demand, I'll fix old messages too.
Project Member

Comment 20 by bugdroid1@chromium.org, Jul 11 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/bedbb409d329ec2ab37573964b725203509db126

commit bedbb409d329ec2ab37573964b725203509db126
Author: tandrii <tandrii@google.com>
Date: Mon Jul 11 13:13:06 2016

Sign in to add a comment