Commit queue dry-runs should not pollute codereview message list. |
||||||||||
Issue descriptionSee attached image. Dry runs should not create messages that obfuscate human review comments on patches.
,
Mar 19 2016
,
Mar 20 2016
So, the good thing is that people really like to use Dry Runs :) The is feature request, and it can be done entirely in Rietveld, if necessary CQ can post extra flag for Dry-run-induced messages. As for Gerrit, I am certainly sure that review+try/CQ+land for chromium would be possible before end of Q2.
,
Mar 23 2016
,
Apr 7 2016
Tags will allow the filtering of these messages in the near future: https://gerrit-review.googlesource.com/75803/
,
Apr 26 2016
,
Apr 27 2016
,
Jul 7 2016
,
Jul 7 2016
,
Jul 7 2016
,
Jul 7 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/452eb59a3572da8c5fa8656e0efdb4d2e1a5ead4 commit 452eb59a3572da8c5fa8656e0efdb4d2e1a5ead4 Author: tandrii <tandrii@google.com> Date: Thu Jul 07 16:18:22 2016
,
Jul 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/16906cec5dba67d54736c06754052934b4e49598 commit 16906cec5dba67d54736c06754052934b4e49598 Author: tandrii <tandrii@chromium.org> Date: Thu Jul 07 16:19:23 2016 Rietveld: Mark CQ Dry Run messages as autogenerated. R=rmistry@chromium.org,andybons@chromium.org BUG= 596249 Review-Url: https://codereview.chromium.org/2131593002 [modify] https://crrev.com/16906cec5dba67d54736c06754052934b4e49598/appengine/chromium_rietveld/codereview/views.py
,
Jul 7 2016
Finally, display CQ status url next to commit box
,
Jul 7 2016
,
Jul 7 2016
And related issue to stop sending all emails whatsoever on CQ Dry run http://crbug.com/626427
,
Jul 8 2016
,
Jul 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/9a9c7be53ad1cc67f4492554feebf256c7972f50 commit 9a9c7be53ad1cc67f4492554feebf256c7972f50 Author: tandrii <tandrii@chromium.org> Date: Fri Jul 08 10:50:28 2016 Rietveld: add CQ status URL instead of comment. BUG= 596249 Review-Url: https://codereview.chromium.org/2123093009 [modify] https://crrev.com/9a9c7be53ad1cc67f4492554feebf256c7972f50/appengine/chromium_rietveld/codereview/models.py [modify] https://crrev.com/9a9c7be53ad1cc67f4492554feebf256c7972f50/appengine/chromium_rietveld/codereview/utils.py [modify] https://crrev.com/9a9c7be53ad1cc67f4492554feebf256c7972f50/appengine/chromium_rietveld/codereview/views.py [modify] https://crrev.com/9a9c7be53ad1cc67f4492554feebf256c7972f50/appengine/chromium_rietveld/templates/patchset.html [add] https://crrev.com/9a9c7be53ad1cc67f4492554feebf256c7972f50/appengine/chromium_rietveld/tests/test_utils.py
,
Jul 8 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/c346a10e53866da6d877268a234475ed603fde63 commit c346a10e53866da6d877268a234475ed603fde63 Author: tandrii <tandrii@google.com> Date: Fri Jul 08 12:02:14 2016
,
Jul 8 2016
This has been fixed and deployed. I didn't touch old CQ Dry run messages, as I think it's not worth the effort. However, if there is high demand, I'll fix old messages too.
,
Jul 11 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/bedbb409d329ec2ab37573964b725203509db126 commit bedbb409d329ec2ab37573964b725203509db126 Author: tandrii <tandrii@google.com> Date: Mon Jul 11 13:13:06 2016 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by serg...@chromium.org
, Mar 19 2016Components: -Build
Labels: -Build-CommitQueue Infra-CommitQueue