New issue
Advanced search Search tips

Issue 596247 link

Starred by 4 users

Issue metadata

Status: Archived
Owner:
Closed: Nov 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Improve tabstrip coloration in GTK theme mode?

Reported by rsmith31...@gmail.com, Mar 19 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2679.0 Safari/537.36

Steps to reproduce the problem:
1. Install latest dev version - 51.0.2679.0 dev (64-bit)
2. Open several tabs
3. Look at the background color of the inactive tabs

What is the expected behavior?
A more suitable background color

What went wrong?
First two screenshots show the problem with the GTK and Classic theme enabled, respectively. Third screenshot shows that incognito mode looks great using the Classic theme. Fourth screenshot shows incognito mode with GTK theme in which icons and inactive tabs don't match the overall theme.

Did this work before? Yes Previous version without material design used more suitable colors

Chrome version: 51.0.2679.0  Channel: dev
OS Version: Ubuntu 15.10 GNOME
Flash Version: Shockwave Flash 21.0 r0

Enable other options in the flag "Material design in the browser's top chrome" (chrome://flags) doesn't seem to change anything.
 
Screenshot from 2016-03-18 19-58-19.png
8.3 KB View Download
Screenshot from 2016-03-18 20-00-23.png
8.0 KB View Download
Screenshot from 2016-03-18 20-26-50.png
8.5 KB View Download
Screenshot from 2016-03-18 20-32-48.png
8.1 KB View Download
The screenshots were reordered after submitting this report. 

First screenshot = "Screenshot from 2016-03-18 19-58-19.png". 
Second screenshot = "Screenshot from 2016-03-18 20-26-50.png". 
Third screenshot = "Screenshot from 2016-03-18 20-00-23.png"
Fourth screenshot = "Screenshot from 2016-03-18 20-32-48.png"
Chrome for Mobile.pdf
681 KB Download
Labels: Proj-MaterialDesign-NativeUI
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 4 by est...@chromium.org, Mar 23 2016

Status: Fixed (was: Assigned)
I think the dev build mentioned in the initial report did not have a4db9673a67b98e1bdd7adeb1a866b3e940593ba which should fix this issue.
Thanks. I tested the latest dev (51.0.2687.0 dev) and certainly the Classic theme has been fixed. However, the GTK theme still has the same issue. Do you know if there is an upcoming improvement?

Comment 6 by est...@chromium.org, Mar 24 2016

what's wrong with the GTK theme? It's not clear to me what you want changed. The background color seems perfectly suitable imho.
I attach a screenshot with and without incognito mode using GTK theme. I think the contrast between background color of tabs and their text is not sufficient to make it easily readable. I also upload an image with annotations to describe this better.

Hope that helps.
Screenshot from 2016-03-23 18-54-13.png
8.3 KB View Download
Screenshot from 2016-03-23 18-54-48.png
8.5 KB View Download
chrome-dev-tabs.jpg
30.1 KB View Download

Comment 8 by est...@chromium.org, Mar 24 2016

Labels: -Pri-2 Pri-3
Status: Available (was: Fixed)
Summary: Improve tabstrip coloration in GTK theme mode? (was: Background color in inactive tabs doesn't match GTK or Classic theme)
thanks. I think this is pretty low priority because

a) it's only a little bad, and only because contrast is not sufficiently high
b) it might be hard to fix this in a way that creates a general improvement across all gtk themes
That's okay as long as you're aware of this issue. Fortunately, the classic theme is pretty usable. The only drawback is that "Use GTK+ theme" is set as default, so this change could surprise users.
Project Member

Comment 10 by sheriffbot@chromium.org, Mar 27 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
> a) it's only a little bad, and only because contrast is not sufficiently high

With a dark GTK theme it's way more than a little bad, it's almost unusable. I challenge you to find the active tab in this screenshot in less than 2 seconds.

b) it might be hard to fix this in a way that creates a general improvement across all gtk themes

If using the "notebook tab" and "notebook tab:hover" for inactive tabs and the toolbar/active tab, respectively, is not acceptable (and I don't see why it wouldn't), then I have at least 2 suggestions for ensuring there is enough contrast:

 (i) either subtract an absolute value from the R, G and B values of the active tab/toolbar instead of multiplying them by .8 or whatever you're using; or
 (ii) if the theme is dark (there already exists an IsDark() function in the Chromium GTK integration logic) then lighten the inactive tabs instead of darkening them.

Assuming you start with 20% gray, there is much better contrast between 20% gray and 20% + (100% - 20%) * some_coefficient than between 20% and 20% * some_coefficient. Just sayin'.
Screenshot from 2017-10-27 14-23-41.png
34.5 KB View Download
Cc: thomasanderson@chromium.org
> (i) either subtract an absolute value from the R, G and B values of the active tab/toolbar instead of multiplying them by .8 or whatever you're using

That will not work because some themes use the same color for active and inactive notebook tabs (screenshot)

> (ii) if the theme is dark (there already exists an IsDark() function in the Chromium GTK integration logic) then lighten the inactive tabs instead of darkening them.

estade@ what do you think about this?  The screenshot from c#11 looks pretty bad imo
Screenshot from 2017-10-27 16-11-30.png
5.5 KB View Download
Meant to reply to this in place of (i)

> If using the "notebook tab" and "notebook tab:hover" for inactive tabs and the toolbar/active tab, respectively, is not acceptable 
> That will not work because some themes use the same color for active and inactive notebook tabs (screenshot)

I totally understand your concern (and it's essentially the exact symptom this issue is addressing) but themes are a user choice. If the user feels that identifying the active tab is unimportant to him, then let him have his wish. :o) I am actually using such a theme myself and I went on and manually edited the theme, so now all active tabs everywhere in Gnome are much more visible. Except Chrome, of course.

But because I understand most people won't go to the length that I have and because Chrome seems to take a pretty strong position regarding deriving inactive colors from active ones, I proposed the other alternative. It's essentially similar to applying a negative filter to what happens with a light theme.

And, BTW, thanks for the quick answer.
What do native tabs look like in this theme? With many themes I actually have way more difficulty finding the active tab in my gnome terminal than in Chrome, which calls the functional argument into question. "If the user feels that identifying the active tab is unimportant to him" seems like a straw man; what user would consciously declare this stance? I'm much more concerned with the imperfections inherent in taking colors meant for one set of UI elements and mapping them onto a different set of UI elements.

re #12: I don't think lightening instead of darkening the bg tabs will help visibility and will look good, but if someone wants to try that and we find it improves more themes than it hurts, then I wouldn't be against it. It wouldn't be easy to find the active tab in that screenshot on any theme because the tabstrip is extremely wide yet still overstuffed with tabs to the point that the tab title text becomes near worthless.
> What do native tabs look like in this theme?

Originally, they looked almost exactly as the ones from Thomas' screenshot: same as inactive ones but with a bright underline. I understand Chrome doesn't do that, so I'm not asking for it. Right now though, I've edited the theme and made the active tab significantly brighter than inactive ones (and added borders).

> I'm much more concerned with the imperfections inherent in taking colors meant for one set of UI elements and mapping them onto a different set of UI elements.

I'm not sure I understand what you're getting at here. Aren't Chrome tabs conceptually the same type of UI element as e.g. terminal tabs?

> I don't think lightening instead of darkening the bg tabs will help visibility [...].

I'm pretty sure it will (in fact this is what I did with my theme). Think of it this way: with a bright theme you take a bright color (active tab color) and go let's say 20% of the way to black. Assuming you start with 200 (light gray), that gets you close to 160, so the delta is ~40. Applying the same logic to a dark color will get you from, say, 50 (dark gray) to 40, so a delta of ~10.

What I'm proposing is going from this 50 some 20% of the way to white, so a delta of +40 instead of the current -10. If for some reason you believe it won't look good because the active tab is darker than the inactive ones (in my mind they're just "grayed out"), then apply my proposed logic to produce the 2 colors and use the brighter one for the active tab and the darker one for inactive tabs. I don't care much as long as they can be distinguished from one another.

> It wouldn't be easy to find the active tab in that screenshot on any theme because the tabstrip is extremely wide yet still overstuffed with tabs to the point that the tab title text becomes near worthless.

I've been using Chrome since before it launched, with the classic theme and a number of graphic ones (which I picked for having reasonable contrast for the active tab) and I've always had tens of tabs open. I don't mind not being able to read the (full) title, I use the favicons and keep track of relative tab positions (e.g. previous tab was 2 tabs to the right of the current one). But if I can't locate the active tab then my whole system goes out the window.
Anyone willing to pick this up? It's a simple change and it isn't as controversial as it may appear at first sight.

Any takers? Please? :o)
Status: Assigned (was: Untriaged)
Status: Archived (was: Assigned)

Sign in to add a comment