New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 596242 link

Starred by 4 users
Status: Fixed
Owner:
█ markdittmer@chromium.org
Last visit > 30 days ago
Closed: Apr 2016
Cc:
danakj@chromium.org
█ vollick@chromium.org
penghuang@chromium.org
█ markdittmer@chromium.org
rjkroege@chromium.org
vmi...@chromium.org
piman@chromium.org
sky@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
mus



Sign in to add a comment

ui/gfx/ipc should not directly or indirectly depend on skia

Project Member Reported by fsam...@chromium.org, Mar 19 2016 
Currently gpu_messages depends on ui/gfx/ipc for ParamTraits of things like gfx::Size.

gpu should not depend on skia at all. gpu needs the following from ui/gfx currently (according to piman@):

- geometry (gfx::Size)
- native handles (will move away from ui/ soon),
- GpuMemoryBuffers
- SwapResults.

As per piman@'s suggestion, we should separate those things out of the other ui/gfx things that need skia.

danakj@ suggests a ui/gfx/ipc/geometry as opposed to ui/gfx/geometry/ipc.

Comment 1 by fsam...@chromium.org, Mar 19 2016

Blocking: 586365
Labels: mus
Owner: fsam...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by fsam...@chromium.org, Mar 21 2016

Summary: ui/gfx/ipc should not directly or indirectly depend on skia (was: ui/gfx/ipc should not directly or indirectly spend on skia)

Comment 3 by fsam...@chromium.org, Mar 21 2016

Labels: -Pri-3 Pri-2

Comment 4 by fsam...@chromium.org, Mar 21 2016

Owner: markdittmer@chromium.org
Mark, you said you can focus on this? Thanks. Please assign back to me if I got that wrong.

Comment 5 by markdittmer@chromium.org, Mar 22 2016

Status: Started (was: Assigned)

Comment 6 by fsam...@chromium.org, Mar 22 2016

Cc: sky@chromium.org

Comment 7 by fsam...@chromium.org, Mar 23 2016 

Currently, gpu/ipc/common consists of two source_sets: command_buffer_traits_sources and ipc_common_sources. I think once this issue is resolved, it ought to be possible to merge those source_sets (and associated targets) into one.

Comment 8 by fsam...@chromium.org, Mar 24 2016

Blocking: -586365
As we have a viable workaround (two targets within gpu/ipc/common) I don't think this is blocking 586365 at the moment.
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99d77bf02c02eaa19848b709e53c88157467df69

commit 99d77bf02c02eaa19848b709e53c88157467df69
Author: markdittmer <markdittmer@chromium.org>
Date: Thu Mar 31 19:03:24 2016

Separate gfx_ipc into skia-dependent and non-skia-dependent parts. This will simplify dependencies in gpu/ipc/common, as a part of the content/common/gpu --> gpu refactor.

BUG= 596242 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1824993004

Cr-Commit-Position: refs/heads/master@{#384351}

[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/android_webview/common/render_view_messages.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/chrome/browser/extensions/api/declarative_content/content_action_unittest.cc
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/chrome/browser/extensions/extension_action.cc
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/chrome/chrome_common.gypi
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/chrome/common/BUILD.gn
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/chrome/common/chrome_utility_messages.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/chromecast/common/media/BUILD.gn
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/chromecast/common/media/cma_messages.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/chromecast/common/media/cma_param_traits.cc
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/components/autofill.gypi
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/components/autofill/content/common/BUILD.gn
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/components/autofill/content/common/autofill_messages.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/components/printing/common/BUILD.gn
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/components/printing/common/print_messages.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/child/plugin_messages.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/common/BUILD.gn
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/common/browser_plugin/browser_plugin_messages.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/common/cc_messages.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/common/child_process_messages.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/common/common_param_traits_unittest.cc
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/common/frame_messages.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/common/gpu_host_messages.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/common/input_messages.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/common/media/media_param_traits.cc
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/common/plugin_process_messages.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/common/view_messages.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/content_common.gypi
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/content_shell.gypi
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/content_tests.gypi
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/public/common/BUILD.gn
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/shell/BUILD.gn
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/shell/common/shell_messages.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/content/test/BUILD.gn
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/extensions/common/BUILD.gn
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/extensions/common/extension_messages.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/extensions/common/extension_utility_messages.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/extensions/extensions.gyp
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/extensions/renderer/set_icon_natives.cc
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/printing/pdf_render_settings.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/ui/gfx/ipc/BUILD.gn
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/ui/gfx/ipc/gfx_ipc.gyp
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/ui/gfx/ipc/gfx_param_traits.cc
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/ui/gfx/ipc/gfx_param_traits.h
[add] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/ui/gfx/ipc/skia/BUILD.gn
[add] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/ui/gfx/ipc/skia/gfx_ipc_skia.gyp
[add] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/ui/gfx/ipc/skia/gfx_skia_ipc_export.h
[add] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/ui/gfx/ipc/skia/gfx_skia_param_traits.cc
[add] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/ui/gfx/ipc/skia/gfx_skia_param_traits.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/ui/ozone/BUILD.gn
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/ui/ozone/common/gpu/ozone_gpu_message_params.cc
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/ui/ozone/common/gpu/ozone_gpu_messages.h
[modify] https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69/ui/ozone/ozone.gyp

Comment 10 by markdittmer@chromium.org, Apr 1 2016

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b5dcb16f8d997aa581e019b5384df4f6fccdf4f

commit 1b5dcb16f8d997aa581e019b5384df4f6fccdf4f
Author: markdittmer <markdittmer@chromium.org>
Date: Thu Apr 14 14:29:19 2016

Fix gyp build on ChromeOS for some configurations that are not finding non-skia gfx param traits

BUG= 596242 

Review URL: https://codereview.chromium.org/1883933002

Cr-Commit-Position: refs/heads/master@{#387310}

[modify] https://crrev.com/1b5dcb16f8d997aa581e019b5384df4f6fccdf4f/ui/ozone/ozone.gyp
►

Sign in to add a comment