New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596238 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug

Blocking:
issue 520266



Sign in to add a comment

Infobar button implementations

Project Member Reported by sgabr...@chromium.org, Mar 19 2016

Issue description

Current buttons in infobars need some adjustments as defined in the secondary UI button spec:

White inforbars:
- Use roboto medium 12px
- Ripples should overlay hover state (ripples #4285F4 8%)
- Hover state should be 12% alpha #4285F4
- Button need to have rounded corners.

On Yellow infobar, use normal buttons:
- Text #5A5A5A 
- Hover #000 8% alpha. Ripple #000 6%

Other related specs: https://drive.google.com/a/google.com/folderview?id=0B6x6iYCtKinERVJ6WjNCV21SSmM&usp=sharing




 
SPEC - Chrome Cros - 200 - infobar - theme.png
65.9 KB View Download
SPEC - Chrome Cros - 200 - infobar - restore.png
71.4 KB View Download
Cc: bruthig@chromium.org
Labels: -Proj-MaterialDesign-CrOS Proj-MaterialDesign-NativeUI OS-Linux OS-Windows

Comment 2 by est...@chromium.org, Mar 22 2016

Cc: msw@chromium.org
I don't think we can do medium font weight. Options appear to be bold and normal.

Are we really supposed to use roboto everywhere, or just cros? I didn't even have roboto on my linux machine until I typed

$ sudo apt-get install fonts-roboto
Aren't we bundling the entire roboto weightl library? Is that still ongoing ? I remember a thread about adding all the weights in to solve this specific kind of problem. Roboto medium is used extensively throughout and we need it.

I know medium is available on the Cros platform because we use it in built-in apps.

It's for just cros, the fate of windows buttons haven't been decided yet.

Comment 4 by msw@chromium.org, Mar 22 2016

Here's the font weights CL I'm reviewing: http://codereview.chromium.org/1819753003

Comment 5 by est...@chromium.org, Mar 22 2016

re #4: sweet, maybe medium will be possible soon then.

re #3: you were probably discussing webui.

Comment 6 by est...@chromium.org, Mar 23 2016

although not specified here, sgabriel also mentioned in chat that a single button should have the weak call to action styling, whereas with pairs of buttons the confirm action should have the strong call to action styling.
Blocking: 520266
After further deliberations, sgabriel wants to try strong CTA for all solitary buttons. Weak CTA will not appear anywhere in infobars.
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81cd5c907f341cbfe18e22c12a1315d6266fbf53

commit 81cd5c907f341cbfe18e22c12a1315d6266fbf53
Author: estade <estade@chromium.org>
Date: Wed Apr 13 00:15:35 2016

[MD] Use strong call to action styling on solitary infobar buttons.

BUG= 596238 

Review URL: https://codereview.chromium.org/1871133002

Cr-Commit-Position: refs/heads/master@{#386873}

[modify] https://crrev.com/81cd5c907f341cbfe18e22c12a1315d6266fbf53/chrome/browser/ui/views/infobars/confirm_infobar.cc

Labels: Merge-Request-51
request merge for 81cd5c907f341cbfe18e22c12a1

Comment 12 by tin...@google.com, Apr 13 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 14 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45b570898356b9ba55f48d55bc8a2a30d12d9498

commit 45b570898356b9ba55f48d55bc8a2a30d12d9498
Author: Evan Stade <estade@chromium.org>
Date: Thu Apr 14 00:42:29 2016

[MD] Use strong call to action styling on solitary infobar buttons.

BUG= 596238 

Review URL: https://codereview.chromium.org/1871133002

Cr-Commit-Position: refs/heads/master@{#386873}
(cherry picked from commit 81cd5c907f341cbfe18e22c12a1315d6266fbf53)

Review URL: https://codereview.chromium.org/1886163002 .

Cr-Commit-Position: refs/branch-heads/2704@{#45}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/45b570898356b9ba55f48d55bc8a2a30d12d9498/chrome/browser/ui/views/infobars/confirm_infobar.cc

Labels: TE-Verified-M51 TE-Verified-51.0.2704.7
Tested the issue on Ubuntu 14.04, Windows 7 using 51.0.2704.7.Working as intended.
Please find attached screenshot.

Marking it as TE-Verified.
596238.png
18.6 KB View Download
Status: Fixed (was: Assigned)

Sign in to add a comment