New issue
Advanced search Search tips

Issue 596209 link

Starred by 3 users
Status: Untriaged
Owner: ----
Cc:
jam@chromium.org
xhw...@chromium.org
mcasas@chromium.org
mlamouri@chromium.org
sa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Task

Blocking:
issue 593607



Sign in to add a comment

Move Permissions API parts in content/child to third_party.WebKit

Project Member Reported by mcasas@chromium.org, Mar 18 2016 
Permissions API implements [1] by having:
1 - idls and associated code in Source/modules/permissions
2 - Platform data types and interfaces in 
 public/platform/modules/permissions
3 - content code in content/child/permissions
4 - mojom files in 
content/common/permission_service.mojom
content/public/common/permission_status.mojom
5 - browser side impls of the mojo services in 
content/browser/permissions
6 - and some more stuff in chrome/browser/permissions
and other similar embedder impls.

this bug as part of the Onion Soup project tracks moving
3 and 4 to 2 (or even to 1 if Source/modules can directly
talk mojo).


[1] http://w3c.github.io/permissions/

Comment 1 by mcasas@chromium.org, Mar 18 2016

IMG_20160318_155623~2.jpg
1.0 MB View Download

Comment 2 by mlamouri@chromium.org, Mar 21 2016

Cc: -peter@chromium.org sa...@chromium.org
+sammc@ who is currently working on this.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcd191dc45a3114ffbe1305b38b27e19b91a32c7

commit fcd191dc45a3114ffbe1305b38b27e19b91a32c7
Author: sammc <sammc@chromium.org>
Date: Fri Apr 01 10:03:03 2016

Move geolocation and permission mojoms into WebKit/public/platform.

BUG=593607, 596209
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1771743002

Cr-Commit-Position: refs/heads/master@{#384536}

[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/android_webview/browser/aw_permission_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/android_webview/browser/aw_permission_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/blimp/engine/app/blimp_permission_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/blimp/engine/app/blimp_permission_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chrome/browser/DEPS
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chrome/browser/notifications/notification_permission_context_unittest.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chrome/browser/permissions/permission_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chrome/browser/permissions/permission_manager_unittest.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chrome/browser/push_messaging/push_messaging_service_impl.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chrome/browser/push_messaging/push_messaging_service_impl.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chromecast/browser/cast_permission_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chromecast/browser/cast_permission_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/DEPS
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/background_sync/background_sync_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/background_sync/background_sync_service_impl_unittest.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/geolocation/geolocation_service_context.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/geolocation/geolocation_service_context.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/geolocation/geolocation_service_impl.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/geolocation/geolocation_service_impl.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/media/cdm/browser_cdm_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/media/cdm/browser_cdm_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/permissions/permission_service_context.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/permissions/permission_service_context.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/permissions/permission_service_impl.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/permissions/permission_service_impl.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/push_messaging/push_messaging_message_filter.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/child/permissions/permission_dispatcher.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/child/permissions/permission_dispatcher.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/common/BUILD.gn
[delete] https://crrev.com/4d2a651896cbc5c01de890fefc05e1a8e61eddbe/content/common/geolocation_service.mojom
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/content_common_mojo_bindings.gyp
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/public/browser/permission_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/public/common/BUILD.gn
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/renderer/geolocation_dispatcher.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/renderer/geolocation_dispatcher.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/renderer/media/media_permission_dispatcher.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/renderer/media/media_permission_dispatcher.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/renderer/media/midi_dispatcher.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/renderer/media/midi_dispatcher.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/renderer/notification_permission_dispatcher.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/renderer/notification_permission_dispatcher.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/browser/layout_test/layout_test_message_filter.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/browser/layout_test/layout_test_message_filter.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/browser/layout_test/layout_test_notification_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/browser/layout_test/layout_test_permission_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/browser/layout_test/layout_test_permission_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/browser/layout_test/layout_test_push_messaging_service.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/browser/shell_permission_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/browser/shell_permission_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/common/layout_test/layout_test_messages.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/test/mock_permission_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/test/mock_permission_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/third_party/WebKit/public/blink.gyp
[add] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/third_party/WebKit/public/platform/modules/geolocation/OWNERS
[rename] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/third_party/WebKit/public/platform/modules/geolocation/geolocation.mojom
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/third_party/WebKit/public/platform/modules/permissions/OWNERS
[rename] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/third_party/WebKit/public/platform/modules/permissions/permission.mojom
[rename] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/third_party/WebKit/public/platform/modules/permissions/permission_status.mojom

Comment 4 by xhw...@chromium.org, Apr 5 2016

Cc: xhw...@chromium.org jam@chromium.org
As discussed in https://chromiumcodereview.appspot.com/1838903007/, we ("media") need PermissionServices as well. Note that "media" doesn't depend on "content", nor "blink". The current proposal is to move Permission mojom into components/permission so that it can be accessed by other components in chromium. Let me know what you think about it?

If it seems good, would anybody be able to help do this? I am OOO this week. If not, I'll see whether I can do it once I am back.

Comment 5 by xhw...@chromium.org, Apr 18 2016 

I filed issue 604503 to track the proposal in #4.

Comment 6 by tkent@chromium.org, Jun 23 2016

Components: -Blink>Architecture Blink>Internals
Renaming Blink>Architecture to Blink>Internals
Project Member

Comment 7 by sheriffbot@chromium.org, Jun 23 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by andypaicu@chromium.org, Nov 6

Labels: -Type-Bug Type-Task
►

Sign in to add a comment