Currently struct_traits_unittest.cc is disabled because of this.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aef38024a1d6d99deb565a89cd7dd8b3bc21f971 commit aef38024a1d6d99deb565a89cd7dd8b3bc21f971 Author: yzshen <yzshen@chromium.org> Date: Sat Mar 19 00:34:40 2016 Mojo C++ bindings: assume that all imported mojoms have the same variant as current mojom. This CL also disable struct_traits_unittest because variant+typemap is not supported currently. BUG= 596202 , 596162 Review URL: https://codereview.chromium.org/1816703002 Cr-Commit-Position: refs/heads/master@{#382143} [modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/mojo_edk_tests.gyp [modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/mojo_public.gyp [modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/cpp/bindings/tests/BUILD.gn [modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/interfaces/bindings/tests/BUILD.gn [modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/interfaces/bindings/tests/blink_test.typemap [modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/interfaces/bindings/tests/chromium_test.typemap [modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/interfaces/bindings/tests/test_native_types.mojom [modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/interfaces/bindings/tests/test_variant.mojom [add] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/interfaces/bindings/tests/test_variant_import.mojom [modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/tools/bindings/generators/cpp_templates/module-internal.h.tmpl [modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl [modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl [modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/tools/bindings/generators/mojom_cpp_generator.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1107b7873a0b930ff197da68c3eaacd751839d5 commit a1107b7873a0b930ff197da68c3eaacd751839d5 Author: sammc <sammc@chromium.org> Date: Wed Mar 23 18:51:58 2016 Mojo bindings: Fix typemap includes. Previously, a header defining a StructTraits specialization could not include its corresponding generated mojom header, due to the mojom header including the StructTraits header. This required a brittle set of forward declarations to correctly avoid this; in practice, this mostly led to StructTraits that were nominally for a particular variant, but included the generated mojom header from the default variant. This CL fixes the issue by splitting typemap headers into public_headers, which define the native type and are included by the generated mojom header, and headers which define the StructTraits specialization for the native type and are only included by the generated mojom source file, allowing the StructTraits header to include the generated mojom header. BUG= 596202 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel Review URL: https://codereview.chromium.org/1821073002 Cr-Commit-Position: refs/heads/master@{#382893} [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/components/mus/ws/window_manager_factory_service.cc [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/content/common/BUILD.gn [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/content/content_common_mojo_bindings.gyp [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/gpu/command_buffer/common/mojo.typemap [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/mojo_edk_tests.gyp [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/mojo_public.gyp [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/cpp/bindings/tests/BUILD.gn [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/cpp/bindings/tests/rect_blink.h [add] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/cpp/bindings/tests/rect_blink_traits.h [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/cpp/bindings/tests/rect_chromium.h [add] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/cpp/bindings/tests/rect_chromium_traits.h [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/cpp/bindings/tests/struct_with_traits_impl.cc [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/cpp/bindings/tests/struct_with_traits_impl.h [add] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.cc [add] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/interfaces/bindings/tests/BUILD.gn [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/interfaces/bindings/tests/blink_test.typemap [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/interfaces/bindings/tests/chromium_test.typemap [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/interfaces/bindings/tests/rect.mojom [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/interfaces/bindings/tests/struct_with_traits.typemap [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/interfaces/bindings/tests/test_native_types.mojom [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/tools/bindings/generators/cpp_templates/module-internal.h.tmpl [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/tools/bindings/generators/mojom_cpp_generator.py [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/mojo/public/tools/bindings/mojom.gni [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/url/mojo/BUILD.gn [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/url/mojo/gurl.typemap [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/url/mojo/origin.typemap [modify] https://crrev.com/a1107b7873a0b930ff197da68c3eaacd751839d5/url/url.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/565c598ea3ef433ffb084d88794eea271b2beee8 commit 565c598ea3ef433ffb084d88794eea271b2beee8 Author: sammc <sammc@chromium.org> Date: Tue Apr 05 23:37:52 2016 Mojo: Generate Java mojom targets when !cpp_only. Previously, Java mojom targets were generated unless a variant was specified or typemaps were used. However, Java mojom targets should be generated for the default variant regardless of whether typemaps are used. This cl fixes this by switching on the same variable as all the other decisions for whether to generate Java bindings. BUG= 596202 Review URL: https://codereview.chromium.org/1852163002 Cr-Commit-Position: refs/heads/master@{#385324} [modify] https://crrev.com/565c598ea3ef433ffb084d88794eea271b2beee8/mojo/public/tools/bindings/mojom.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b54ee6567f200280a284fc466706962fa810e398 commit b54ee6567f200280a284fc466706962fa810e398 Author: sammc <sammc@chromium.org> Date: Tue Apr 19 08:07:36 2016 Mojo: Simplify typemap usage. Previously, to use native types in mojo interfaces, the correct typemaps needed to be set on each target depending on the mojom target containing that interface. Additionally, each variant required a duplicate set of mojom targets for all the mojom files required by that variant. This CL changes the mojom GN template to generate a mojom target for each variant, applying the appropriate typemaps when generating the bindings. This is controlled by mojo bindings configurations that aggregate all of the typemaps for that configuration and specify the variant for that configuration. To accommodate this change, this also changes the typemap format to be one GN-format file per mojom file, setting variables that specify the typemap. At build time, the typemap information and any dependencies are used to generate a JSON typemap of the old JSON format containing all typemaps for the bindings being generated as well as their dependencies. This makes minor changes to typemap support in GYP. With this CL, typemaps can be specified as GYP variables instead of directly specifying them in extra generator command line arguments. CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel BUG= 596202 Review URL: https://codereview.chromium.org/1832703002 Cr-Commit-Position: refs/heads/master@{#388164} [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/components/mus/public/interfaces/BUILD.gn [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/components/password_manager.gypi [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/components/password_manager/content/public/interfaces/BUILD.gn [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/content/common/BUILD.gn [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/content/content_common_mojo_bindings.gyp [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/gpu/command_buffer/common/BUILD.gn [add] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/gpu/command_buffer/common/capabilities.typemap [add] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/gpu/command_buffer/common/command_buffer.typemap [add] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/gpu/command_buffer/common/mailbox.typemap [add] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/gpu/command_buffer/common/mailbox_holder.typemap [delete] https://crrev.com/1b15ff2842d798a28388685a6fe75b80a5b808db/gpu/command_buffer/common/mojo.typemap [add] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/gpu/command_buffer/common/sync_token.typemap [add] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/gpu/command_buffer/common/typemaps.gni [add] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/gpu/command_buffer/common/value_state.typemap [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/gpu/ipc/common/BUILD.gn [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mash/wm/public/interfaces/BUILD.gn [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/android/BUILD.gn [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/mojo_edk_tests.gyp [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/mojo_public.gyp [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/mojom_bindings_generator.gypi [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/mojom_bindings_generator_explicit.gypi [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/cpp/bindings/BUILD.gn [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/cpp/bindings/tests/BUILD.gn [add] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/cpp/bindings/tests/blink_typemaps.gni [add] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/cpp/bindings/tests/chromium_typemaps.gni [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/cpp/bindings/tests/pickle_unittest.cc [add] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/cpp/bindings/tests/rect_blink.typemap [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/cpp/bindings/tests/rect_blink_traits.h [add] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/cpp/bindings/tests/rect_chromium.typemap [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/cpp/bindings/tests/rect_chromium_traits.h [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/cpp/bindings/tests/struct_traits_unittest.cc [add] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/cpp/bindings/tests/struct_with_traits.typemap [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/cpp/bindings/tests/struct_with_traits_impl.h [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h [add] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/cpp/bindings/tests/test_native_types_blink.typemap [add] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/cpp/bindings/tests/test_native_types_chromium.typemap [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/cpp/bindings/tests/wtf_types_unittest.cc [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/interfaces/bindings/tests/BUILD.gn [delete] https://crrev.com/1b15ff2842d798a28388685a6fe75b80a5b808db/mojo/public/interfaces/bindings/tests/blink_test.typemap [delete] https://crrev.com/1b15ff2842d798a28388685a6fe75b80a5b808db/mojo/public/interfaces/bindings/tests/chromium_test.typemap [delete] https://crrev.com/1b15ff2842d798a28388685a6fe75b80a5b808db/mojo/public/interfaces/bindings/tests/struct_with_traits.typemap [delete] https://crrev.com/1b15ff2842d798a28388685a6fe75b80a5b808db/mojo/public/interfaces/bindings/tests/test_variant.mojom [delete] https://crrev.com/1b15ff2842d798a28388685a6fe75b80a5b808db/mojo/public/interfaces/bindings/tests/test_variant_import.mojom [add] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/tools/bindings/blink_bindings_configuration.gni [add] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/tools/bindings/chromium_bindings_configuration.gni [add] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/tools/bindings/format_typemap_generator_args.py [add] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/tools/bindings/generate_type_mappings.py [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/mojo/public/tools/bindings/mojom.gni [delete] https://crrev.com/1b15ff2842d798a28388685a6fe75b80a5b808db/mojo/public/tools/bindings/mojom_get_generator_typemap_args.py [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/third_party/WebKit/Source/modules/BUILD.gn [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/third_party/WebKit/Source/web/BUILD.gn [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/third_party/WebKit/public/BUILD.gn [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/third_party/WebKit/public/blink.gyp [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/url/mojo/BUILD.gn [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/url/mojo/gurl.typemap [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/url/mojo/origin.typemap [add] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/url/mojo/typemaps.gni [modify] https://crrev.com/b54ee6567f200280a284fc466706962fa810e398/url/url.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c8396083e862032a031f843fd9087eb751f3227 commit 0c8396083e862032a031f843fd9087eb751f3227 Author: sammc <sammc@chromium.org> Date: Tue Apr 26 05:23:55 2016 Mojo: Change the blink variant from "wtf" to "blink". BUG= 596202 Review URL: https://codereview.chromium.org/1902263004 Cr-Commit-Position: refs/heads/master@{#389704} [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/device/usb/usb.gyp [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/mojo/mojo_public.gyp [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/mojo/mojom_bindings_generator.gypi [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/mojo/mojom_bindings_generator_explicit.gypi [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/mojo/public/cpp/bindings/tests/BUILD.gn [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/mojo/public/cpp/bindings/tests/pickle_unittest.cc [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/mojo/public/cpp/bindings/tests/rect_blink_traits.h [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/mojo/public/cpp/bindings/tests/struct_traits_unittest.cc [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/mojo/public/cpp/bindings/tests/wtf_types_unittest.cc [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/mojo/public/tools/bindings/blink_bindings_configuration.gni [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/BUILD.gn [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/payments/PaymentRequest.h [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/payments/PaymentResponse.h [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/payments/ShippingAddress.cpp [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/payments/ShippingAddress.h [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/payments/ShippingAddressTest.cpp [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/webusb/USB.cpp [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/webusb/USB.h [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/webusb/USBAlternateInterface.cpp [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/webusb/USBAlternateInterface.h [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/webusb/USBConfiguration.cpp [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/webusb/USBConfiguration.h [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/webusb/USBDevice.cpp [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/webusb/USBDevice.h [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/webusb/USBEndpoint.cpp [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/webusb/USBEndpoint.h [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/webusb/USBInterface.cpp [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/modules/webusb/USBInterface.h [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/web/BUILD.gn [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/public/BUILD.gn [modify] https://crrev.com/0c8396083e862032a031f843fd9087eb751f3227/third_party/WebKit/public/blink.gyp
Comment 1 by bugdroid1@chromium.org
, Mar 19 2016