New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596197 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

shill mixes up "unknown error" and "no error"

Project Member Reported by semenzato@chromium.org, Mar 18 2016

Issue description

Shill uses kFailureUnknown for both success and unknown errors.  This results in confusing log messages and possibly other internal confusion.
 
Labels: OSSystemsNetwork
What happened to the component menu for labels???

Comment 2 by snanda@chromium.org, Mar 18 2016

Components: OS>Systems>Network
Labels: -OSSystemsNetwork
Status: WontFix (was: Assigned)
Moved to b/27767401.
Labels: -Pri-3 Pri-2
Status: Started (was: WontFix)
Moving back here since we forked shill.

Comment 6 by quiche@chromium.org, May 22 2018

Cc: -quiche@chromium.org
Cc: akhouderchah@chromium.org
Do you mind if I take over on this Luigi? It's a shame that your CL was reverted just because shill's unit tests are... questionable; this has been annoying me since I first looked at our logs.

Reverted CL for posterity:
https://android-review.googlesource.com/c/platform/system/connectivity/shill/+/209433
Owner: ----
Please do.  FYI, here's the CL I started.

https://android-review.googlesource.com/c/platform/system/connectivity/shill/+/209433/

Cc: -akhouderchah@chromium.org semenzato@chromium.org
Owner: akhouderchah@chromium.org

Sign in to add a comment