error-toast-sk showing up with a blank error message for server errors in ct.skia.org and push.skia.org and maybe others |
||||
Issue descriptionWhen starting a task on cluster telemetry, I'm getting a 500 server error. The request is going to: https://ct.skia.org/_/add_chromium_perf_task And responds with: 500 Internal Server Error
,
Mar 18 2016
I submitted a test task that seemed to work ok: https://ct.skia.org/queue/ What parameters are you specifying?
,
Mar 18 2016
Not able to look at the logs right now because not on VPN.
,
Mar 18 2016
Can you try this patch? https://codereview.chromium.org/1812153002 Both wkorman and I were able to repro with it. (Apply to chromium)
,
Mar 18 2016
Yeah, I literally pasted '1812153002' into the 'Chromium Git patch' field, and clicked 'Queue Task', and I get a 500 server error every time.
,
Mar 21 2016
,
Mar 21 2016
Using https://codereview.chromium.org/1812153002 in ct.skia.org worked for me. Applying the patch failed though: https://uberchromegw.corp.google.com/i/skia-ct-master//run_chromium_perf_on_workers.build101-m5.chrome-bot.log.INFO.rmistry-20160321124932 Could you try it again? maybe it was a transient issue with Rietveld.
,
Mar 21 2016
Also, are you signed in to ct.skia.org ? When I am not signed in I get the issue described in https://codereview.chromium.org/1812153002#msg7 I will take a look at why the popup is blank.
,
Mar 21 2016
Renaming the bug. Reproducable in both ct.skia.org and push.skia.org when users are not logged in. Caused by https://codereview.chromium.org/1704713002/diff/60001/go/util/http.go All callers which do not specify a message will see this bug. The previous behavior displayed the error message and thus not all callers needed to specify a message.
,
Mar 21 2016
Sorry, I should have thought of this problem when reviewing https://codereview.chromium.org/1704713002.
,
Mar 21 2016
The following revision refers to this bug: https://skia.googlesource.com/buildbot.git/+/ace4c3c09b2c97d0fcf045d727473665348e4bf8 commit ace4c3c09b2c97d0fcf045d727473665348e4bf8 Author: rmistry <rmistry@google.com> Date: Mon Mar 21 19:52:57 2016 Update callers of httputils.ReportError to specify message. Use "Unknown error" when message is not specified so that the error toast is never blank. Context is in https://bugs.chromium.org/p/chromium/issues/detail?id=596183#c9 BUG= chromium:596183 Review URL: https://codereview.chromium.org/1820863002 [modify] https://crrev.com/ace4c3c09b2c97d0fcf045d727473665348e4bf8/ct/go/ctfe/chromium_builds/chromium_builds.go [modify] https://crrev.com/ace4c3c09b2c97d0fcf045d727473665348e4bf8/ct/go/ctfe/chromium_perf/chromium_perf.go [modify] https://crrev.com/ace4c3c09b2c97d0fcf045d727473665348e4bf8/ct/go/ctfe/task_common/task_common.go [modify] https://crrev.com/ace4c3c09b2c97d0fcf045d727473665348e4bf8/datahopper_internal/go/datahopper_internal/main.go [modify] https://crrev.com/ace4c3c09b2c97d0fcf045d727473665348e4bf8/go/httputils/http.go [modify] https://crrev.com/ace4c3c09b2c97d0fcf045d727473665348e4bf8/push/go/push/main.go
,
Mar 22 2016
Pushed new releases and verified that it now works on ct.skia.org and on push.skia.org Marking as fixed. |
||||
►
Sign in to add a comment |
||||
Comment 1 by rmis...@google.com
, Mar 18 2016Labels: -Pri-2 Pri-1
Owner: benjamin...@chromium.org