New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596183 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

error-toast-sk showing up with a blank error message for server errors in ct.skia.org and push.skia.org and maybe others

Project Member Reported by pdr@chromium.org, Mar 18 2016

Issue description

When starting a task on cluster telemetry, I'm getting a 500 server error.

The request is going to:
https://ct.skia.org/_/add_chromium_perf_task

And responds with:
500 Internal Server Error
 

Comment 1 by rmis...@google.com, Mar 18 2016

Cc: rmis...@chromium.org
Labels: -Pri-2 Pri-1
Owner: benjamin...@chromium.org

Comment 2 by rmis...@google.com, Mar 18 2016

I submitted a test task that seemed to work ok: https://ct.skia.org/queue/
What parameters are you specifying?

Comment 3 by rmis...@google.com, Mar 18 2016

Not able to look at the logs right now because not on VPN.

Comment 4 by pdr@chromium.org, Mar 18 2016

Can you try this patch? https://codereview.chromium.org/1812153002

Both wkorman and I were able to repro with it. (Apply to chromium)
Yeah, I literally pasted '1812153002' into the 'Chromium Git patch' field, and clicked 'Queue Task', and I get a 500 server error every time.

Comment 6 by rmis...@google.com, Mar 21 2016

Cc: -rmis...@chromium.org benjamin...@chromium.org
Owner: rmis...@chromium.org
Status: Started (was: Assigned)

Comment 7 by rmis...@google.com, Mar 21 2016

Using https://codereview.chromium.org/1812153002 in ct.skia.org worked for me.

Applying the patch failed though:
https://uberchromegw.corp.google.com/i/skia-ct-master//run_chromium_perf_on_workers.build101-m5.chrome-bot.log.INFO.rmistry-20160321124932

Could you try it again? maybe it was a transient issue with Rietveld.

Comment 8 by rmis...@google.com, Mar 21 2016

Also, are you signed in to ct.skia.org ?

When I am not signed in I get the issue described in https://codereview.chromium.org/1812153002#msg7 I will take a look at why the popup is blank.

Comment 9 by rmis...@google.com, Mar 21 2016

Cc: stephana@chromium.org jcgregorio@chromium.org
Summary: error-toast-sk showing up with a blank error message for server errors in ct.skia.org and push.skia.org and maybe others (was: Cluster telemetry 500 server error)
Renaming the bug.

Reproducable in both ct.skia.org and push.skia.org when users are not logged in.

Caused by https://codereview.chromium.org/1704713002/diff/60001/go/util/http.go
All callers which do not specify a message will see this bug. The previous behavior displayed the error message and thus not all callers needed to specify a message.
Sorry, I should have thought of this problem when reviewing https://codereview.chromium.org/1704713002.

Comment 12 by rmis...@google.com, Mar 22 2016

Status: Fixed (was: Started)
Pushed new releases and verified that it now works on ct.skia.org and on push.skia.org
Marking as fixed.

Sign in to add a comment