New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596181 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 29 days ago
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Using up/down arrows in the attribute editor will modify a URL

Project Member Reported by brentons@google.com, Mar 18 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.87 Safari/537.36

Steps to reproduce the problem:
1. Edit Attribute with a URL (e.g. src="http://longassurl.com/thing/12345") 
2. Hit the up/down arrows to navigate between lines

What is the expected behavior?
The cursor moves to a higher or lower line.

What went wrong?
The attribute editor seems to think the URL is a CSS property and will increment the first number is finds in a URL.  Since URLs often contain complex hashes, a user trying to copy/paste a URL may not notice the change and end up with an invalid URL.

Did this work before? N/A 

Chrome version: 49.0.2623.87  Channel: stable
OS Version: OS X 10.11.2
Flash Version: Shockwave Flash 21.0 r0

Multiline attributes should use up/down for navigation, rather than value incrementing.  Perhaps URLs should be blocked from incrementing with up/down arrows altogether.
 

Comment 1 by caseq@chromium.org, Mar 18 2016

Components: -Platform>DevTools Platform>DevTools>HTML
Owner: lushnikov@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 3 2016

Labels: Hotlist-Google
Are we talking about HTML attributes here?
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d3e6d4a5d416197864ddc2a329b84ce5124667d

commit 9d3e6d4a5d416197864ddc2a329b84ce5124667d
Author: lushnikov <lushnikov@chromium.org>
Date: Sat Jul 30 03:06:58 2016

DevTools: do not apply number editings shortcuts to HTML attributes which look like URL

BUG= 596181 
R=dgozman

Review-Url: https://codereview.chromium.org/2197653004
Cr-Commit-Position: refs/heads/master@{#408853}

[modify] https://crrev.com/9d3e6d4a5d416197864ddc2a329b84ce5124667d/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

Status: Fx (was: Assigned)
Status: Fixed (was: Fx)

Sign in to add a comment