New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596178 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

MediaRecorder: no video recording produced on a stream that has its AudioTrack |disable|d

Reported by cpaulin@chromium.org, Mar 18 2016

Issue description

Version: 51.0.2684.0 linux

MediaRecorder is not able to record a media stream whose audio track is stopped, the video track still being live.

Essentially, we create a audio+video media stream with gUM then we stop the audio track, but keep the video track alive, then try to record the media stream, no video is produced.

Steps to reproduce:
1- Go to https://cdn.rawgit.com/cricdecyan/mediarecorder/master/manualtest/index.html
2- Click on GetUserMedia
3- Click on StopLocalAudioTracks to disable all audio tracks.
4- Click on CreateRecorder
5- Click on Start

Result: the recorder is in 'recording' state but no dataavailable event is fired, thus no video produced.

 

Comment 1 by mcasas@chromium.org, Mar 18 2016

Status: Started (was: Assigned)
Summary: MediaRecorder: no video recording produced on a stream that has its AudioTrack |disable|d (was: MediaRecorder: no video recording produced on a stream that has its AudioTrack stopped )
https://codereview.chromium.org/1812373002/ in the making.

This will probably need 2 content_browsertests, after
landing and verifying.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f621f87b55831af48c2b184c703500884de3d1fd

commit f621f87b55831af48c2b184c703500884de3d1fd
Author: mcasas <mcasas@chromium.org>
Date: Mon Mar 21 08:05:20 2016

MediaRecorder: ignored disabled audio/video tracks on MR start

BUG= 596178 

Review URL: https://codereview.chromium.org/1812373002

Cr-Commit-Position: refs/heads/master@{#382253}

[modify] https://crrev.com/f621f87b55831af48c2b184c703500884de3d1fd/content/renderer/media/media_recorder_handler.cc

Comment 3 by mcasas@chromium.org, Mar 21 2016

Status: Fixed (was: Started)
cpaulin@ please verify 

This functionality needs also a content_browsertest.
Status: Assigned (was: Fixed)
Reopening this bug as the issue is not fixed on Linux ToT chrome version 51.0.2687.0 : I still cannot get any video recorded even though the recorder is in 'recording's state. No dataavailable events fired.

Comment 5 by mcasas@chromium.org, Mar 21 2016

I don't see 51.0.2687.0 in Omaha proxy and there
is no Linux Canary, the closest is Dev:
linux	dev	51.0.2679.0	50.0.2661.18

Anyway the CL landed as 382253, and none of the Canaries
include it yet, e.g.
mac	canary	51.0.2686.0 [...] 382218

So try either ToT compiled or wait until the next
Canary that includes the CL. SG?

We can work in parallel on the content_browsertests.
I have compiled the ToT twice this morning, performed the test twice and my previous comments are from my findings, I have verified that the code contents are in sync with the CL before building. So, I believe my comments on #4 are an accurate representation of the state of the bug.

Comment 7 by mcasas@chromium.org, Mar 22 2016

Status: Started (was: Assigned)
Note that, on the Issue description, step 1 also needs
either --enable-blink-features=GetUserMedia flag or
chrome://flags -> Experimental Web Platform features enabled.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2181b9dfb8af9622a2a87afda9bbc10717721f0b

commit 2181b9dfb8af9622a2a87afda9bbc10717721f0b
Author: mcasas <mcasas@chromium.org>
Date: Tue Mar 22 22:00:44 2016

MediaStreamTrack: don't wait to record MediaStreamTrack's whose state is not 'live'

A MSTrack on which stop() has been called has state 'ended'.
With this CL MR avoids waiting for those Tracks.

BUG= 596178 
TEST= See bug #1:

Steps to reproduce:
1- Go to https://cdn.rawgit.com/cricdecyan/mediarecorder/master/manualtest/index.html
 (note: needs either --enable-blink-features=GetUserMedia flag or
 chrome://flags -> Experimental Web Platform features enabled)
2- Click on GetUserMedia
3- Click on StopLocalAudioTracks to disable all audio tracks.
4- Click on CreateRecorder
5- Click on Start

Review URL: https://codereview.chromium.org/1824933005

Cr-Commit-Position: refs/heads/master@{#382697}

[modify] https://crrev.com/2181b9dfb8af9622a2a87afda9bbc10717721f0b/content/renderer/media/media_recorder_handler.cc

Comment 9 by mcasas@chromium.org, Mar 22 2016

Status: Fixed (was: Started)
cpaulin@ please verify.
Status: Verified (was: Fixed)
Verified with freshly build linux chrome ToT (51.0.2688.0).
Thanks for the fix.
Components: -Blink>MediaStreamRecording Blink>MediaStream>Recording
Renamed component Blink>MediaStreamRecording to Blink>MediaStream>Recording. Moving issues to the new component. 
Components: Blink>MediaRecording
Components: -Blink>MediaStream>Recording

Sign in to add a comment