New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 596162 link

Starred by 1 user
Status: Fixed
Owner:
█ yzshen@chromium.org
Last visit > 30 days ago
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Missing variant name in types passed to Mojo callbacks.

Project Member Reported by reillyg@chromium.org, Mar 18 2016 
For example, if you compile //device/usb/public/interfaces/chooser_service.mojom with for_blink = true and variant = "blink" you get the following definition of the GetPermission method:

using GetPermissionCallback = mojo::Callback<void(device::usb::DeviceInfoPtr)>;
virtual void GetPermission(mojo::WTFArray<device::usb::DeviceFilterPtr> device_    filters, const GetPermissionCallback& callback) = 0;

The DeviceInfoPtr type that the callback expects is device::usb::DeviceInfoPtr instead of device::usb::blink::DeviceInfoPtr.

Comment 1 by yzshen@chromium.org, Mar 18 2016

Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aef38024a1d6d99deb565a89cd7dd8b3bc21f971

commit aef38024a1d6d99deb565a89cd7dd8b3bc21f971
Author: yzshen <yzshen@chromium.org>
Date: Sat Mar 19 00:34:40 2016

Mojo C++ bindings: assume that all imported mojoms have the same variant as current mojom.

This CL also disable struct_traits_unittest because variant+typemap is not supported currently.

BUG= 596202 , 596162 

Review URL: https://codereview.chromium.org/1816703002

Cr-Commit-Position: refs/heads/master@{#382143}

[modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/mojo_edk_tests.gyp
[modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/mojo_public.gyp
[modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/cpp/bindings/tests/BUILD.gn
[modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/interfaces/bindings/tests/BUILD.gn
[modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/interfaces/bindings/tests/blink_test.typemap
[modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/interfaces/bindings/tests/chromium_test.typemap
[modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/interfaces/bindings/tests/test_native_types.mojom
[modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/interfaces/bindings/tests/test_variant.mojom
[add] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/interfaces/bindings/tests/test_variant_import.mojom
[modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/tools/bindings/generators/cpp_templates/module-internal.h.tmpl
[modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl
[modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl
[modify] https://crrev.com/aef38024a1d6d99deb565a89cd7dd8b3bc21f971/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

Comment 3 by yzshen@chromium.org, Mar 21 2016

Status: Fixed (was: Started)
►

Sign in to add a comment