Convert the Python interpreter check to a Verifier
Reported by
jrbarnette@chromium.org,
Mar 18 2016
|
|||||
Issue description
CrosHost.verify_software() includes this check to make sure
a Python interpreter is available:
# Makes sure python is present, loads and can use built in functions.
# We have seen cases where importing cPickle fails with undefined
# symbols in cPickle.so.
self.run('python -c "import cPickle"')
The code needs to be converted to a Verifier, as for bug 586317.
Note that the call to 'self.run()' above produces an
exception that's much to long for use as a status.log
error message; failures need to be caught and the message
simplified.
,
Apr 15 2016
,
Apr 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2321ffddcf4248bf2f6fff42dd155f5ee25d0d99 commit 2321ffddcf4248bf2f6fff42dd155f5ee25d0d99 Author: Richard Barnette <jrbarnette@chromium.org> Date: Fri Apr 15 16:22:25 2016 [autotest] Convert the check for a working python to a verifier. This move the check for a working python interpreter from CrosHost.verify_software() into a new, purpose-built Verifier subclass. This further adjusts the repair triggers to properly recognize and handle the new verifier. BUG= chromium:596153 TEST=power-wash and verify a DUT. Change-Id: I4eab0cba8b76e22b9259eced6623216d6b113ac3 Reviewed-on: https://chromium-review.googlesource.com/339076 Commit-Ready: Richard Barnette <jrbarnette@chromium.org> Tested-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: Dan Shi <dshi@google.com> [modify] https://crrev.com/2321ffddcf4248bf2f6fff42dd155f5ee25d0d99/server/hosts/cros_host.py [modify] https://crrev.com/2321ffddcf4248bf2f6fff42dd155f5ee25d0d99/server/hosts/cros_repair.py
,
Apr 19 2016
,
Apr 27 2016
,
May 23 2016
Bulk verified |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by autumn@chromium.org
, Mar 28 2016