New issue
Advanced search Search tips

Issue 596147 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Crash in test_runner::TestPlugin::initialize

Project Member Reported by ClusterFuzz, Mar 18 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6478446850473984

Fuzzer: mbarbella_js_mutation_layout
Job Type: windows_syzyasan_content_shell
Platform Id: windows

Crash Type: UNKNOWN
Crash Address: 0x00000003
Crash State:
  test_runner::TestPlugin::initialize
  blink::FrameLoaderClientImpl::createPlugin
  blink::HTMLPlugInElement::loadPlugin
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=windows_syzyasan_content_shell&range=381525:381877

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv96eMIqfcejjm2sP-g0TPIVcm3xbNnPjuP9N1eO1fxoPYTZdVTSRoWU9gwxt_mKf55GrCT0CTQrlH_dcsZcwCdf4ZVAcqkqmuIXdefbWXTh8beS6XXkM3a85v_Si12CLZOlUsDCBrE4B0a4XPQrTQTnfxCMW974tk2cpc_xraI-1xOoCrVo


Filer: ligimole

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Labels: Test-Findit-CorrectResult M-51 Te-Logged
Owner: danakj@chromium.org
Status: Assigned (was: Available)
Possible suspect
================
https://chromium.googlesource.com/chromium/src//+/823b7378c01290d0a29e2052554d497e87530490

Lines 178 of file test_plugin.cc which potentially caused crash are changed in this cl (frame #0, "content_shell!test_runner::TestPlugin::initialize+0x45").
Minimum distance from crash line to modified line: 0. (file: test_plugin.cc, crashed on: 178, modified: 178).

Comment 2 by danakj@chromium.org, Mar 18 2016

Cc: piman@chromium.org
https://code.google.com/p/chromium/codesearch#chromium/src/components/test_runner/test_plugin.cc&l=178 will crash on disable-gpu I think. context_ will be null there. gl_ should be null too.

Comment 3 by piman@chromium.org, Mar 18 2016

Agreed, context_ can be null, and equivalently, gl_ should be set to null in that case.

Comment 4 by danakj@chromium.org, Mar 18 2016

Labels: -Restrict-View-EditIssue allpublic
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7865b1d30daf6e4b75d8fe89768828e09b44caee

commit 7865b1d30daf6e4b75d8fe89768828e09b44caee
Author: danakj <danakj@chromium.org>
Date: Fri Mar 18 22:18:40 2016

Fix crash without GPU in test_plugin.cc

When GPU isn't available, context_ will be null. gl_ should be equally
null in that case, and we should not deref the context_.

R=pfeldman@chromium.org, piman@chromium.org
TBR=pfeldman
BUG= 596147 

Review URL: https://codereview.chromium.org/1817463003

Cr-Commit-Position: refs/heads/master@{#382110}

[modify] https://crrev.com/7865b1d30daf6e4b75d8fe89768828e09b44caee/components/test_runner/test_plugin.cc

Comment 6 by danakj@chromium.org, Mar 18 2016

Status: Fixed (was: Assigned)
Project Member

Comment 7 by ClusterFuzz, Mar 20 2016

ClusterFuzz has detected this testcase as flaky and is unable to reproduce it in the original crash revision. Skipping fixed testing check and marking it as potentially fixed.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6478446850473984

Fuzzer: mbarbella_js_mutation_layout
Job Type: windows_syzyasan_content_shell
Platform Id: windows

Crash Type: UNKNOWN
Crash Address: 0x00000003
Crash State:
  test_runner::TestPlugin::initialize
  blink::FrameLoaderClientImpl::createPlugin
  blink::HTMLPlugInElement::loadPlugin
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=windows_syzyasan_content_shell&range=381525:381877

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv96eMIqfcejjm2sP-g0TPIVcm3xbNnPjuP9N1eO1fxoPYTZdVTSRoWU9gwxt_mKf55GrCT0CTQrlH_dcsZcwCdf4ZVAcqkqmuIXdefbWXTh8beS6XXkM3a85v_Si12CLZOlUsDCBrE4B0a4XPQrTQTnfxCMW974tk2cpc_xraI-1xOoCrVo


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Comment 8 by danakj@chromium.org, Mar 21 2016

 Issue 596492  has been merged into this issue.

Sign in to add a comment