New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596145 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 0
Type: ----



Sign in to add a comment

Window builder bots failing in repeated "trigger" steps on chromium.perf

Project Member Reported by petrcermak@chromium.org, Mar 18 2016

Issue description

Link to buildbot status page:
https://build.chromium.org/p/chromium.perf/builders/Win%20Builder
https://build.chromium.org/p/chromium.perf/builders/Win%20x64%20Builder/

Both bots fail with the following steps after successful "package build": "trigger", "trigger (2)", "trigger (3)", ...

Sample "trigger" step (https://build.chromium.org/p/chromium.perf/builders/Win%20Builder/builds/5438/steps/trigger%20%282%29/logs/stdio):

@@@STEP_CURSOR@trigger (2)@@@
@@@STEP_STARTED@@@
@@@STEP_TRIGGER@{"bucket": null, "builderNames": ["Win 7 Low-End Perf (2)"], "changes": [], "properties": {"parent_got_angle_revision": "00f394ec669faa3a778180991204caa474eb1dd2", "parent_got_nacl_revision": "06cacd6becc3f033d03fab97e6fa9ef99d9b41f2", "parent_got_revision": "1b495549523fcccb2290c2d3b9f10d54794557b6", "parent_got_revision_cp": "refs/heads/master@{#382013}", "parent_got_swarming_client_revision": "df6e95e7669883c8fe9ef956c69a544154701a49", "parent_got_v8_revision": "b57a275ad5e89473423dab8e5a4987bff802ad0a", "parent_got_v8_revision_cp": "refs/heads/5.1.172@{#1}", "parent_got_webrtc_revision": "957d59940ee89546313c590cac9369b0f8d81bf3", "parent_got_webrtc_revision_cp": "refs/heads/master@{#12049}"}, "tags": null}@@@
@@@STEP_TEXT@Win 7 Low-End Perf (2)@@@
Will wait till async operations complete:
* Triggering build(s) on Win 7 Low-End Perf (2)
--------------------------------------------------------------------------------
started: Fri Mar 18 11:34:10 2016
ended: Fri Mar 18 11:34:11 2016
duration: 0 secs
status: FAILURE
status reason: step was unfinished at finalization.

Perhaps the bots need to be restarted.
 

Comment 1 by vhang@google.com, Mar 21 2016

Owner: jo...@chromium.org
Status: Assigned (was: Untriaged)
Bot health sheriff ping!
These builders are still failing on the waterfall.
Any update?

Comment 3 by jo...@chromium.org, Mar 21 2016

These have all been restarted now, although the health of the systems seemed to be fine. Recommend troopers take a look if the problem persists. 

Comment 4 by jo...@chromium.org, Mar 21 2016

Labels: -Infra-Labs
Owner: ----
Status: Untriaged (was: Assigned)
Over to troopers.

Comment 5 by stip@chromium.org, Mar 21 2016

Ugh. I can't find logs or error requests of why the build is failing. I can't even find logs on the master. Something really weird is going on here.
Cc: dtu@chromium.org
Labels: -Pri-1 Pri-0
From sizes step failure on the builders, this is what it shows:

@@@STEP_TEXT@sizes@@@
@@@STEP_TEXT@<div class="BuildResultInfo">@@@
@@@STEP_TEXT@</div>@@@
Traceback (most recent call last):
  File "C:\b\build\scripts\slave\runtest.py", line 1951, in <module>
    sys.exit(main())
  File "C:\b\build\scripts\slave\runtest.py", line 1916, in main
    result = _MainWin(options, args, extra_env)
  File "C:\b\build\scripts\slave\runtest.py", line 1489, in _MainWin
    perf_dashboard_id=options.perf_dashboard_id)
  File "C:\b\build\scripts\slave\annotation_utils.py", line 123, in annotate
    raise Exception('runtest.py error: perf step specified but'
Exception: runtest.py error: perf step specified butno test_id in factory_properties!

Comment 7 by aga...@chromium.org, Mar 22 2016

Status: Started (was: Untriaged)
This is the breaking CL: https://codereview.chromium.org/1809783003

It added the new sizes step. The step fails because it specifies '--annotate=graphic' (which causes it to use the performance_log_processor.GraphingLogProcessor), but doesn't specify '--options.perf_dashboard_id', which is necessary for the GraphingLogProcessor to work.

I'm reverting the CL.
Owner: aga...@chromium.org

Comment 9 by aga...@chromium.org, Mar 22 2016

Cc: h...@chromium.org
Revert here: https://codereview.chromium.org/1827443002/
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/91a548ce90a89cabefd2048030c959a39e7bb534

commit 91a548ce90a89cabefd2048030c959a39e7bb534
Author: agable@chromium.org <agable@chromium.org>
Date: Tue Mar 22 17:15:05 2016

Revert of Run Sizes on Windows perf builders (patchset #1 id:1 of https://codereview.chromium.org/1809783003/ )

Reason for revert:
New sizes step always fails: https://build.chromium.org/p/chromium.perf/builders/Win%20Builder/builds/5630/steps/sizes/logs/stdio

See https://bugs.chromium.org/p/chromium/issues/detail?id=596145#c7 for additional details

Original issue's description:
> Run Sizes on Windows perf builders
> 
> I want to be able to track down Windows size regressions with the win perf
> trybots.
> 
> BUG= 457078 
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299385

TBR=eakuefner@chromium.org,dtu@chromium.org,eakuefner@google.com,prasadv@chromium.org,robertocn@chromium.org,thakis@chromium.org,hans@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 457078 , 596145 

Review URL: https://codereview.chromium.org/1827443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299424 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/91a548ce90a89cabefd2048030c959a39e7bb534/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py
[modify] https://crrev.com/91a548ce90a89cabefd2048030c959a39e7bb534/scripts/slave/recipes/chromium.expected/full_chromium_perf_Win_Builder.json
[modify] https://crrev.com/91a548ce90a89cabefd2048030c959a39e7bb534/scripts/slave/recipes/chromium.expected/full_chromium_perf_Win_x64_Builder.json
[modify] https://crrev.com/91a548ce90a89cabefd2048030c959a39e7bb534/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_win_8_perf_bisect.json
[modify] https://crrev.com/91a548ce90a89cabefd2048030c959a39e7bb534/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_win_fyi_perf_bisect.json
[modify] https://crrev.com/91a548ce90a89cabefd2048030c959a39e7bb534/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_win_perf_bisect.json
[modify] https://crrev.com/91a548ce90a89cabefd2048030c959a39e7bb534/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_win_perf_bisect_builder.json
[modify] https://crrev.com/91a548ce90a89cabefd2048030c959a39e7bb534/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_win_x64_perf_bisect.json
[modify] https://crrev.com/91a548ce90a89cabefd2048030c959a39e7bb534/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64_10_perf_bisect.json
[modify] https://crrev.com/91a548ce90a89cabefd2048030c959a39e7bb534/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64_10_perf_cq.json
[modify] https://crrev.com/91a548ce90a89cabefd2048030c959a39e7bb534/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64_bisect_builder.json
[modify] https://crrev.com/91a548ce90a89cabefd2048030c959a39e7bb534/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64_zen_perf_bisect.json
[modify] https://crrev.com/91a548ce90a89cabefd2048030c959a39e7bb534/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64ati_perf_bisect.json
[modify] https://crrev.com/91a548ce90a89cabefd2048030c959a39e7bb534/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64intel_perf_bisect.json
[modify] https://crrev.com/91a548ce90a89cabefd2048030c959a39e7bb534/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64nvidia_perf_bisect.json

Comment 11 by h...@chromium.org, Mar 22 2016

Cc: qyears...@chromium.org
 Issue 596934  has been merged into this issue.
This is the first build to start since the revert: https://build.chromium.org/p/chromium.perf/builders/Win%20Builder/builds/5634

If it goes green I'll close this bug.
Status: Fixed (was: Started)
Yep, it went green.

Sign in to add a comment