this also applies to the tab throbber. This theme doesn't provide TINT_BUTTONS, so we fall back to the default for incognito, which is light-on-dark. We should probably fall back to the default for non-incognito, even in incognito, whenever there's a custom theme.

 Issue 597927  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66736a7734ef10200f9a653502464260877fd397

commit 66736a7734ef10200f9a653502464260877fd397
Author: estade <estade@chromium.org>
Date: Wed Mar 30 01:26:23 2016

Don't fall back to default incognito colors and tints when using a
custom theme.

BUG= 596136 

Review URL: https://codereview.chromium.org/1813393002

Cr-Commit-Position: refs/heads/master@{#383895}

[modify] https://crrev.com/66736a7734ef10200f9a653502464260877fd397/chrome/browser/themes/theme_service.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66736a7734ef10200f9a653502464260877fd397

commit 66736a7734ef10200f9a653502464260877fd397
Author: estade <estade@chromium.org>
Date: Wed Mar 30 01:26:23 2016

Don't fall back to default incognito colors and tints when using a
custom theme.

BUG= 596136 

Review URL: https://codereview.chromium.org/1813393002

Cr-Commit-Position: refs/heads/master@{#383895}

[modify] https://crrev.com/66736a7734ef10200f9a653502464260877fd397/chrome/browser/themes/theme_service.cc

Evan, I think we should merge this back into M-50; the change seems very low risk to me and it does fix a visual regression we have introduced. WDYT?

seems fine to me. Can someone besides me verify the fix (I assume you noticed it as well on some other theme).

Your change meets the bar and is auto-approved for M50 (branch: 2661)

Verified on ToT (@384026). Has not yet landed on Chrome OS canary.

good enough for me

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e74fd51a4eb0b3f7571b3dc39e5ec09dcf972a8

commit 3e74fd51a4eb0b3f7571b3dc39e5ec09dcf972a8
Author: Evan Stade <estade@chromium.org>
Date: Thu Mar 31 16:40:38 2016

Don't fall back to default incognito colors and tints when using a custom theme.

BUG= 596136 

Review URL: https://codereview.chromium.org/1813393002

Cr-Commit-Position: refs/heads/master@{#383895}
(cherry picked from commit 66736a7734ef10200f9a653502464260877fd397)

Review URL: https://codereview.chromium.org/1852463002 .

Cr-Commit-Position: refs/branch-heads/2661@{#445}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/3e74fd51a4eb0b3f7571b3dc39e5ec09dcf972a8/chrome/browser/themes/theme_service.cc