New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 596135 link

Starred by 2 users
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

AppToolbarButton should use colors from color_palette.h

Project Member Reported by shrike@chromium.org, Mar 18 2016 
And I see that in typing values in by hand I accidentally swapped two of them :-/.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d56cbf38e2e9791c43fb313d7ad200cd031ca61

commit 3d56cbf38e2e9791c43fb313d7ad200cd031ca61
Author: shrike <shrike@chromium.org>
Date: Fri Mar 18 21:08:03 2016

Use colors from color_palette.h

This button hardcodes colors that appear in color_palette.h - not good
(though I only became aware of that header after working on the class).

BUG= 596135 

Review URL: https://codereview.chromium.org/1815313002

Cr-Commit-Position: refs/heads/master@{#382085}

[modify] https://crrev.com/3d56cbf38e2e9791c43fb313d7ad200cd031ca61/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm

Comment 2 by shrike@chromium.org, Mar 18 2016

Status: Fixed (was: Started)
►

Sign in to add a comment