New issue
Advanced search Search tips

Issue 596134 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Android GN debug build has no debugging information for Java local variables.

Project Member Reported by aber...@chromium.org, Mar 18 2016

Issue description

If I build an Android Debug build with GN, and try it debug it in Eclipse, I don't see any local variables in the Eclipse debug variables window, I just see the |this| pointer. This works correctly with GYP.
 
Summary: Android GN debug build has no debugging information for Java local variables. (was: Android GN debug build has debugging information for Java local variables.)
Cc: pkotw...@chromium.org agrieve@chromium.org

Comment 3 by agrieve@google.com, Mar 18 2016

When looking into this before, I found there's a --no-locals dex flag (which sounds like it would cause this behaviour). However, it's set only in release mode. No idea why it's happening...
Owner: yfried...@chromium.org
Status: Started (was: Untriaged)
Thanks for the pionter, Andrew, I think I see why:
build/android/gyp/dex.py

  if options.no_locals != '0':                                                                        

well, it's not default set to 0 in GN
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c1bca05189d7e8024b848e25ecb2813b53b6056

commit 5c1bca05189d7e8024b848e25ecb2813b53b6056
Author: yfriedman <yfriedman@chromium.org>
Date: Thu Mar 24 00:14:05 2016

Default no-locals to 0 in dex.py.

gyp always specified a value for --no-locals when compiling targets but
GN doesn't.

This resulted in GN erroneously stripping them.
BUG= 596134 

Review URL: https://codereview.chromium.org/1830693003

Cr-Commit-Position: refs/heads/master@{#382985}

[modify] https://crrev.com/5c1bca05189d7e8024b848e25ecb2813b53b6056/build/android/gyp/dex.py

Status: Fixed (was: Started)

Sign in to add a comment