New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 596129 link

Starred by 1 user
Status: Fixed
Owner:
jbudorick@chromium.org
Closed: Mar 2016
Cc:
█ hush@chromium.org
changwan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

No upstream android bot runs findbugs

Project Member Reported by boliu@chromium.org, Mar 18 2016 
Clang builder GYP_DEFINES still has run_findbugs. But it's building with gn now..

Comment 1 by jbudorick@chromium.org, Mar 18 2016

Status: Assigned (was: Untriaged)
not building with gn yet, but not using the GYP_DEFINES you see in runhooks. Instead, it's using these: https://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder%20%28dbg%29/builds/76884/steps/generate_build_files/logs/stdio

Comment 2 by hush@chromium.org, Mar 18 2016 

oh... maybe that's why https://codereview.chromium.org/1809013002 slipped the grasp of findbugs

Comment 3 by jbudorick@chromium.org, Mar 18 2016 

Yeah, it is. Sorry about that. I'll fix this later today.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/770540fe386f8b44ae332b3a6ddc75b06f84a181

commit 770540fe386f8b44ae332b3a6ddc75b06f84a181
Author: jbudorick <jbudorick@chromium.org>
Date: Sat Mar 19 00:40:48 2016

[Android] Reenable findbugs on android_clang_dbg_recipe and Android Clang Builder (dbg).

BUG= 596129 

Review URL: https://codereview.chromium.org/1812393002

Cr-Commit-Position: refs/heads/master@{#382150}

[modify] https://crrev.com/770540fe386f8b44ae332b3a6ddc75b06f84a181/tools/mb/mb_config.pyl

Comment 5 by jbudorick@chromium.org, Mar 19 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment