New issue
Advanced search Search tips

Issue 596111 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 600469



Sign in to add a comment

CL patch file list should include files not uploaded

Project Member Reported by k...@chromium.org, Mar 18 2016

Issue description

Currently, if you 'git cl upload' a large file (apparently defined as >1MB), it would be included in a local 'git cl land' but does not show up in the corresponding 'codereview.chromium.org/###' patch file list. The author doesn't know why this is without going through the same search that others have in the past, and people doing code forensics aren't getting a complete/correct picture.

It would be much better to at least list the file, with a disclaimer to the effect of, "(not uploaded due to large size, commit locally - git cl land)"
 

Comment 1 by aga...@chromium.org, Apr 27 2016

Components: Infra>Codereview
Labels: -Infra-Codereview
Blockedon: 600469
Cc: -andyb...@chromium.org
Status: Available (was: Untriaged)
Components: -Infra>Codereview Infra>Codereview>Rietveld
Status: WontFix (was: Available)
Closing in bulk due to Rietveld’s deprecation in favor of Gerrit. If you feel this bug should not have been closed, please feel free to re-open.

Sign in to add a comment