New issue
Advanced search Search tips

Issue 596103 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 583774



Sign in to add a comment

Make the different occurrences of the sign in screen consistent

Project Member Reported by peconn@chromium.org, Mar 18 2016

Issue description

Currently the sign in screen shows up in 4 different places (5 if you count the sign in promo), and it looks different in each place (due to being in a different container each time).
 
2016-03-18_17-18-42.png
209 KB View Download
2016-03-18_17-18-54.png
219 KB View Download
2016-03-18_17-19-02.png
208 KB View Download
2016-03-18_17-19-08.png
185 KB View Download

Comment 1 by peconn@chromium.org, Mar 18 2016

Blockedon: 583774

Comment 2 by ew...@chromium.org, Mar 18 2016

For what it's worth, here are some portrait screenshots on mobile (attached).

In both cases, the only one that looks off/weird to me is the sign in screen shown from the bookmarks access point.

There are two changes I think we should make:

1) The negative button for recent tabs should read "No thanks" instead of "Cancel"
2) The sign in screen shown from the bookmarks access point should look the same as the sign in screen shown from the FRE, but the button text should still read "Cancel" (as opposed to "No thanks"). I.e. it should have the same layout as the FRE sign in screen, but with a different negative button text.
Screenshot_20160318-102249.png
302 KB View Download
Screenshot_20160318-102230.png
317 KB View Download
Screenshot_20160318-102225.png
302 KB View Download
Screenshot_20160318-102217.png
306 KB View Download

Comment 3 by ew...@chromium.org, Mar 18 2016

Labels: -Pri-3 M-51 Pri-2
Status: Assigned (was: Untriaged)

Comment 4 by ew...@chromium.org, Mar 18 2016

Note I don't think this is launch blocking for M50, we can address this in M51.

Comment 5 by ew...@chromium.org, Mar 30 2016

With the upcoming changes for Narnia 2.0, this also might just not be relevant anymore.

Comment 6 by ew...@chromium.org, May 9 2016

Peter - this has been fixed now, right? If so, maybe we can just update the title of this bug to reflect that we are making our metrics recording consistent as well now.
Yes it has.

So merge it with 608179?

Comment 8 by ew...@chromium.org, May 9 2016

Status: Fixed (was: Assigned)
Oh right, forgot we already had Issue 608179 :)

Let's just close this out as Fixed.

Sign in to add a comment