Issue metadata
Sign in to add a comment
|
9.4% regression in page_cycler.intl_ko_th_vi at 381708:381728 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Mar 25 2016
Kicked off a bisect in https://chromeperf.appspot.com/buildbucket_job_status/9017185460022268096
,
Mar 29 2016
,
Mar 29 2016
This also bisected down to gavinp@'s change.
,
Mar 29 2016
Issue 596052 has been merged into this issue.
,
Mar 29 2016
For reference, here's the change: https://codereview.chromium.org/1790483003 , this is discussed in results pasted into issue 596065 . I don't expect any change in performance from this; but I am not an expert on what exactly these finch controls do. asvitkine, can you comment?
,
Mar 29 2016
The CL enabled that field trial group to be tested by the perf bots and browser tests. It means that the field trial group that was enabled is responsible for the regression (assuming it's clear from bisect that it's that CL).
,
Mar 29 2016
Aha, then we would expect that. In Canary and Dev, windows simple cache does have problems. E.G. see that we're proceeding to beta only in non-windows platforms. Thanks asvitkine. So I guess this is expected.
,
Mar 29 2016
In that case, I think the right path is reverting the Windows testing config part of the change to restore the performance here on Windows - which shouldn't affect your trial plan for non-Windows platforms.
,
Mar 29 2016
asvitkine: even though we continue to have a canary trial in Windows? OK. I am heading out very shortly, but I can write that revert up later tonight.
,
Mar 29 2016
Yep, that should be OK. The testing config is required for experimenting on beta and stable.
,
Mar 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/688b2ddd12857e078b629d3d7be1574efdb712e6 commit 688b2ddd12857e078b629d3d7be1574efdb712e6 Author: gavinp <gavinp@chromium.org> Date: Wed Mar 30 16:11:09 2016 Revert SimpleCache fieldtrial testing information on windows. This is not needed for the beta push, and the current state of SimpleCache on windows makes this a regression. BUG= 596100 ,490029 TBR=asvitkine Review URL: https://codereview.chromium.org/1843633005 Cr-Commit-Position: refs/heads/master@{#383994} [modify] https://crrev.com/688b2ddd12857e078b629d3d7be1574efdb712e6/testing/variations/fieldtrial_testing_config_win.json
,
Mar 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/688b2ddd12857e078b629d3d7be1574efdb712e6 commit 688b2ddd12857e078b629d3d7be1574efdb712e6 Author: gavinp <gavinp@chromium.org> Date: Wed Mar 30 16:11:09 2016 Revert SimpleCache fieldtrial testing information on windows. This is not needed for the beta push, and the current state of SimpleCache on windows makes this a regression. BUG= 596100 ,490029 TBR=asvitkine Review URL: https://codereview.chromium.org/1843633005 Cr-Commit-Position: refs/heads/master@{#383994} [modify] https://crrev.com/688b2ddd12857e078b629d3d7be1574efdb712e6/testing/variations/fieldtrial_testing_config_win.json
,
Apr 1 2016
Graphs have recovered. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by tdres...@chromium.org
, Mar 18 2016