Issue metadata
Sign in to add a comment
|
OOPIFs: Device scale factor incorrect on ChromeOS |
||||||||||||||||||||||||
Issue descriptionVersion: 50.0.2661.32 OS: ChromeOS What steps will reproduce the problem? (1) Enable --site-per-process in about:flags and restart (or put a dev mode Pixel into --isolate-extensions mode using /etc/chrome_dev.conf). (2) Install an extension that hosts a web iframe (e.g., https://chrome.google.com/webstore/detail/beautify-fb/ldngjhkgckijklngngononnejmadojce). (3) Visit a page with an OOPIF (e.g., options page of the above extension). What is the expected output? What do you see instead? The OOPIF should be drawn at the same scale factor as the rest of the page. Instead, the text and images are tiny and the scrollbar is strangely widened. Lucas, can you take a look?
,
Mar 23 2016
,
Mar 23 2016
I can repro the issue, it's CrOs-only, it doesn't repro on windows/mac/linux.
,
Mar 29 2016
CrOs doesn't set the device scale factor on the top-level page, it sets the page zoom level instead. This should be resolved as soon as we implement zoom for RemoteFrames.
,
Mar 29 2016
Ah, nice. Thanks for tracking that down!
,
Mar 29 2016
Just to document things a bit more, the zoom level is set here: https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/render_view_impl.cc&l=3439&rcl=1459265830 So, depending on how we replicate the zoom from parent->child, we may need to do extra work to set this parameter. Also, this was a regression when oshima@ introduced DSF zoom in october.
,
May 2 2016
Hmm, I just tested --isolate-extensions on 51.0.2704.29 on a Chromebook Pixel and OOPIFs no longer show up at the wrong resolution. That's strange, because it doesn't have wjmaclean's r390755, which is what we thought was needed for this. (Also, I can confirm that zooming doesn't work in the OOPIF yet.) Maybe ChromeOS fixed it some other way since M50? Anyway, I'll mark this fixed and not a duplicate of issue 528407 .
,
May 2 2016
That is interesting. Does it also work for site-per-process without isolate-extensions?
,
May 2 2016
Yep.
,
May 2 2016
use-zoom-for-dsf is currently on on channels. Can you enable it on the flag and test?
,
May 2 2016
oshima: That explains it! If I enable use-zoom-for-dsf, it's broken again on 51.0.2704.29. I suspect it will be fixed on 52.0.2721.0 or higher when that reaches ChromeOS Dev Channel. I'll mark this as a dupe of issue 528407 again, and we can verify when it reaches Dev. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by creis@chromium.org
, Mar 18 2016415 KB
415 KB View Download