return_code bisect output confusing on failure to reproduce |
|||||
Issue descriptionExample from https://bugs.chromium.org/p/chromium/issues/detail?id=596035#c2: ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Reland - Update DevTools Tracing.Start to accept trace config as a parameter Author : zhenw ... chromium@381891 0 N/A 5 good chromium@381892 0 N/A 5 bad This output is really confusing! It's true that the score was 0.0, but with all the chaos that is waterfall perf sheriffing, I can easily imagine reverting zhenw's CL because of this output. Can we make it clearer the failure did not occur?
,
Mar 21 2016
,
Mar 23 2016
,
Mar 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/b7fdd24b96d77c5243bf6e470932b650dcf9d98b commit b7fdd24b96d77c5243bf6e470932b650dcf9d98b Author: robertocn@chromium.org <robertocn@chromium.org> Date: Wed Mar 23 22:20:47 2016 Making check_initial_confidence verify return_code bisects. This is the code that performs the repro check. We had mistakenly assumed that it only really aplied to perf bisects. R=prasadv,qyearsley BUG= 596086 Review URL: https://codereview.chromium.org/1825993003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299453 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/b7fdd24b96d77c5243bf6e470932b650dcf9d98b/scripts/slave/recipe_modules/auto_bisect/bisector.py [modify] https://crrev.com/b7fdd24b96d77c5243bf6e470932b650dcf9d98b/scripts/slave/recipe_modules/auto_bisect/bisector_test.py [modify] https://crrev.com/b7fdd24b96d77c5243bf6e470932b650dcf9d98b/scripts/slave/recipe_modules/auto_bisect/revision_state.py [modify] https://crrev.com/b7fdd24b96d77c5243bf6e470932b650dcf9d98b/scripts/slave/recipes/bisect.expected/basic_return_code_test.json
,
Apr 25 2016
,
Feb 3 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by petrcermak@chromium.org
, Mar 18 2016