Issue metadata
Sign in to add a comment
|
10.2%-1200% regression in webrtc_perf_tests at 12023:12024 |
||||||||||||||||||||
Issue descriptionSee graphs below.
,
Mar 21 2016
Hi Alex, these performance regressions look like they're caused by your CL: https://codereview.webrtc.org/1773173002 , could you have a look to see if that's expected? Thanks!
,
Mar 22 2016
Well, it definitively is expected that the complexity increases since we don't downsample in the reverse stream. But the increase seems unreasonably high. I am going to have a look next week.
,
Mar 29 2016
aluebs: will you have time to look into this bug this week?
,
Mar 29 2016
Yes, I will look into it this week.
,
Mar 30 2016
Here I have a CL up for review that should at least get rid of the crazy high values: https://codereview.webrtc.org/1844583003/ But some increase in complexity in the reverse stream is expected, since the splitting filter is used instead of the downsampler.
,
Apr 1 2016
The CL landed, but I am not sure I can see the impact it had on this regression.
,
Apr 5 2016
My CL improved many of the metrics, but also surfaced a threading issue, that is tracked here: https://bugs.chromium.org/p/chromium/issues/detail?id=599944 Closing this bug favor of that one, but feel free to re-open if you have any concerns. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ivoc@chromium.org
, Mar 18 2016