Extension Buttons don't get clipped by the AppMenu border |
|||||
Issue descriptionVersion: ToT Repro Steps: 1. Have a Chrome Extension installed and drag the icon into the AppMenu. 2. Decrease screen resolution so the AppMenu has the scroll arrows at the top and bottom. (You can use Ctrl+Shift+'+') 3. Open the AppMenu. 4. Perform a Drag and Drop operation on the extension button that drops it inside the AppMenu still. This causes the menu to be re-sized such that the top of the menu is below the AppMenu button. 5. Scroll down in the App menu. Expected Results: I expect the extension icons to get clipped and not appear outside of the menu bounds. Actual Results: The extension icons are visible above the menu bounds. See attached "app menu clipping issue.png" image. The two rows of icons above the AppMenu should NOT be visible.
,
Mar 18 2016
Weird, I tried to attach that picture when I created the bug. Not sure what happened. Anyway, CL: https://codereview.chromium.org/1812303002/
,
Apr 12 2016
,
Apr 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4aa8a6f3be2aafda269f33e9d88a44083210b71b commit 4aa8a6f3be2aafda269f33e9d88a44083210b71b Author: bruthig <bruthig@chromium.org> Date: Tue Apr 12 21:00:35 2016 Added Layer based clipping to MenuScrollViewContainer::MenuScrollView ToolbarActionViews now own their own Layers so that they can host the material design ripple. The icons were previously clipped via the clipping bounds set on the Canvas passed through the OnPaint() methods. This clipping mechanism no longer works because the icons are painted to their own Layers. Thus this CL updates the MenuScrollView to perform Layer based clipping. BUG= 596073 TEST=manual Review URL: https://codereview.chromium.org/1812303002 Cr-Commit-Position: refs/heads/master@{#386802} [modify] https://crrev.com/4aa8a6f3be2aafda269f33e9d88a44083210b71b/ui/views/controls/menu/menu_scroll_view_container.cc [modify] https://crrev.com/4aa8a6f3be2aafda269f33e9d88a44083210b71b/ui/views/controls/menu/menu_scroll_view_container.h
,
Apr 12 2016
,
Apr 13 2016
,
Apr 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/473354382769d4c53fbb1b5ed13813026bd1218c commit 473354382769d4c53fbb1b5ed13813026bd1218c Author: bruthig <bruthig@chromium.org> Date: Wed Apr 13 12:55:21 2016 Revert of Added Layer based clipping to MenuScrollViewContainer::MenuScrollView (patchset #3 id:40001 of https://codereview.chromium.org/1812303002/ ) Reason for revert: Reverting due to http://crbug.com/602913 Original issue's description: > Added Layer based clipping to MenuScrollViewContainer::MenuScrollView > > ToolbarActionViews now own their own Layers so that they can host the > material design ripple. The icons were previously clipped via the > clipping bounds set on the Canvas passed through the OnPaint() methods. > This clipping mechanism no longer works because the icons are painted > to their own Layers. Thus this CL updates the MenuScrollView to perform > Layer based clipping. > > BUG= 596073 > > TEST=manual > > Committed: https://crrev.com/4aa8a6f3be2aafda269f33e9d88a44083210b71b > Cr-Commit-Position: refs/heads/master@{#386802} TBR=sky@chromium.org,estade@chromium.org,varkha@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 596073 Review URL: https://codereview.chromium.org/1882143004 Cr-Commit-Position: refs/heads/master@{#386974} [modify] https://crrev.com/473354382769d4c53fbb1b5ed13813026bd1218c/ui/views/controls/menu/menu_scroll_view_container.cc [modify] https://crrev.com/473354382769d4c53fbb1b5ed13813026bd1218c/ui/views/controls/menu/menu_scroll_view_container.h
,
Apr 20 2016
,
May 3 2016
Marking as WontFix since the fix for issue 604415 precludes this from happening. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by varkha@chromium.org
, Mar 18 2016