New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 596069 link

Starred by 1 user
Status: WontFix
Owner:
█ chongz@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
w...@chromium.org
dtapu...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 599156



Sign in to add a comment

Reduce Windows key map size by considering AltGr as Ctrl+Alt

Project Member Reported by chongz@chromium.org, Mar 18 2016 
Since AltGr is not defined in valid key combinations, it doesn't need to be stored in the table, and can just return the result for EF_CONTROL_DOWN | EF_ALT_DOWN when looking up EF_ALTGR_DOWN.

Note that although AltGr is defined as CtrlLeft+AltRight, from testing CtrlLeft+AltLeft will also work, and AltRight along will act as AltGr as well, so location doesn't matter so much here.

See Windows scancode doc: https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=8&cad=rja&uact=8&ved=0ahUKEwjS1P38w7nLAhVE2mMKHcVXB1AQFgg6MAc&url=http%3A%2F%2Fdownload.microsoft.com%2Fdownload%2F1%2F6%2F1%2F161ba512-40e2-4cc9-843a-923143f3456c%2Fscancode.doc&usg=AFQjCNFpwWwiM0iIlms4bSL-fVCvRK4K2w&sig2=Cs-Vqgertl3SouKwP1QE4w

Comment 1 by w...@chromium.org, Mar 18 2016 

Not sure what "AltRight alone will act as AltGr as well" - that's due to Windows generating Ctrl+Alt in response to that key, isn't it?  i.e. from this code's point of view we only need to worry about Ctrl+Alt+<key>?

Comment 2 by chongz@chromium.org, Mar 18 2016 

Sorry for the confusion... Yes Windows will simulate Ctrl+Alt when pressing AltRight, so from the code's point of view we only need to worry about Ctrl+Alt+<key>.

Comment 3 by chongz@chromium.org, Mar 30 2016

Labels: -Pri-2 Pri-3

Comment 4 by chongz@chromium.org, Mar 30 2016

Blocking: 599156

Comment 5 by chongz@chromium.org, Apr 1 2016

Components: IO>Keyboard Blink>Input

Comment 6 by dtapu...@chromium.org, Apr 27 2017 

Are we still planning on doing this?

Comment 7 by chongz@chromium.org, May 2 2017

Status: WontFix (was: Assigned)
The benefit of reducing key-map size is too small compared to the cost of adding additional code complexity.

Close as WontFix as I don't think I will prioritize this bug in the near future.
►

Sign in to add a comment