New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 596066 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 599156



Sign in to add a comment

Optimize Windows key map according to "valid key combinations"

Project Member Reported by chongz@chromium.org, Mar 18 2016

Issue description

The building time for the Windows key map could be reduced by only using 90 final keys with 4 two-key combination and 6 three-key combination defined in Windows' scancode doc (https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=8&cad=rja&uact=8&ved=0ahUKEwjS1P38w7nLAhVE2mMKHcVXB1AQFgg6MAc&url=http%3A%2F%2Fdownload.microsoft.com%2Fdownload%2F1%2F6%2F1%2F161ba512-40e2-4cc9-843a-923143f3456c%2Fscancode.doc&usg=AFQjCNFpwWwiM0iIlms4bSL-fVCvRK4K2w&sig2=Cs-Vqgertl3SouKwP1QE4w).

This doc defined 4 (8 located) valid modifiers (Win, Ctrl, Shift, Alt), assuming we don't care about locations there will be 90*(4+6)=900 combinations to try. (current table has 428 entries for US layout so there should still be lots of combinations that won't produce a printable character.)
  

 

Comment 1 by chongz@chromium.org, Mar 30 2016

Labels: -Pri-2 Pri-3

Comment 2 by chongz@chromium.org, Mar 30 2016

Blocking: 599156
Components: IO>Keyboard Blink>Input
Are we still planning on doing this?
Status: WontFix (was: Assigned)
The benefit of reducing key-map computing time is too small compared to the cost of adding additional code complexity (e.g. Readers have to learn about 'final keys' and be able to prove the correctness of the algorithm).

Close as WontFix as I don't think I will prioritize this bug in the near future.

Sign in to add a comment