Issue metadata
Sign in to add a comment
|
Regression : In Chrome Task Manager, focus does not move to End Process button after pressing Tab key.
Reported by
yfulgaon...@etouch.net,
Mar 18 2016
|
||||||||||||||||||||||
Issue descriptionChrome version : 51.0.2682.0 153a9028e5cb73e3c707b4884550499e2a08af5c-refs/heads/master@{#381839} 32/64 bit OS : Windows (Win 7 aero enabled), Linux Steps : 1. Launch Chrome, open NTP and press Shift + Esc key to open the Chrome Task Manager. 2. Click on any process and press Tab key, observe Actual : After pressing Tab key, focus does not move to End Process button. Expected : The focus should move to End Process button after pressing Tab key. This is a regression issue broken in 'M-50' and below is the manual regression and narrow bisect info. Good build : 50.0.2656.0 Bad build : 50.0.2658.0 Narrow Bisect : https://chromium.googlesource.com/chromium/src/+log/b48692ea0b3340d51fb95fa500b176f819623ee1..2b4fc356ff151e0c104596bffea377d6fad40281?pretty=fuller&n=10000 Suspecting : r376888 from Narrow Bisect Note : Above issue is not seen on Mac OS.
,
Mar 21 2016
Just to update, issue is still observed on chrome version 51.0.2686.0 on Windows and Ubuntu 14.04. @karandeepb: request you to please take a look into it.
,
Mar 21 2016
I have confirmed that the issue is due to my CL. Will be working on a fix. However, I think its too late to merge to M50. Changing to M51.
,
Mar 22 2016
,
Mar 30 2016
@karandeepb: Hey, would you mind providing an update on the above issue as it is reproducible on Ubuntu 14.04 & Windows with chrome version '51.0.2693.2'. Appreciate your response. Thank you!
,
Mar 30 2016
@ashejole: I had put up a CL for this which was under review - https://codereview.chromium.org/1826433002/. However, I am OOO this week. You can expect the fix to land next week.
,
Mar 30 2016
@karandeep: Thanks for the update, much appreciated.
,
Apr 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5b001fd75dc0fc7dbe265020ffbd84be9916d5c commit e5b001fd75dc0fc7dbe265020ffbd84be9916d5c Author: karandeepb <karandeepb@chromium.org> Date: Mon Apr 11 01:21:46 2016 DialogClientView: Fix regression in Chrome Task Manager focusing. This CL fixes a regression introduced in https://codereview.chromium.org/1690133003/. The regression is caused since the TaskManagerView, adds child views to the DialogClientView. However, DialogClientView::SetupFocusChain does not account for externally added child views. This CL uses View::ReorderChildView to reorder child views and ensure that appropriate focus order is maintained. Also the redundant contents_ view in DialogClientViewTest is removed. BUG= 596045 , 586419 Review URL: https://codereview.chromium.org/1826433002 Cr-Commit-Position: refs/heads/master@{#386324} [modify] https://crrev.com/e5b001fd75dc0fc7dbe265020ffbd84be9916d5c/ui/views/window/dialog_client_view.cc [modify] https://crrev.com/e5b001fd75dc0fc7dbe265020ffbd84be9916d5c/ui/views/window/dialog_client_view_unittest.cc
,
Apr 13 2016
Have verified this is Windows Canary.
,
Apr 13 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/026a1371d6544af1856aa83e3077139a7c2aae39 commit 026a1371d6544af1856aa83e3077139a7c2aae39 Author: Trent Apted <tapted@chromium.org> Date: Wed Apr 13 00:34:57 2016 [merge] DialogClientView: Fix regression in Chrome Task Manager focusing. This CL fixes a regression introduced in https://codereview.chromium.org/1690133003/. The regression is caused since the TaskManagerView, adds child views to the DialogClientView. However, DialogClientView::SetupFocusChain does not account for externally added child views. This CL uses View::ReorderChildView to reorder child views and ensure that appropriate focus order is maintained. Also the redundant contents_ view in DialogClientViewTest is removed. BUG= 596045 , 586419 TBR=karandeepb@chromium.org Review URL: https://codereview.chromium.org/1826433002 Cr-Commit-Position: refs/heads/master@{#386324} (cherry picked from commit e5b001fd75dc0fc7dbe265020ffbd84be9916d5c) Review URL: https://codereview.chromium.org/1879273002 . Cr-Commit-Position: refs/branch-heads/2704@{#20} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/026a1371d6544af1856aa83e3077139a7c2aae39/ui/views/window/dialog_client_view.cc [modify] https://crrev.com/026a1371d6544af1856aa83e3077139a7c2aae39/ui/views/window/dialog_client_view_unittest.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Mar 18 2016